Skip to content

Rollup of 9 pull requests#156967

Merged
rust-bors[bot] merged 23 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-cDWgT7T
May 26, 2026
Merged

Rollup of 9 pull requests#156967
rust-bors[bot] merged 23 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-cDWgT7T

Conversation

@JonathanBrouwer
Copy link
Copy Markdown
Contributor

Successful merges:

r? @ghost

Create a similar rollup

mejrs and others added 23 commits May 5, 2026 18:26
loongarch: Use `intrinsics::simd` for vrepl{128}ve{0,i}
hexagon-gen: add optional output-dir argument
…, r=folkertdev

stdarch subtree update

Subtree update of `stdarch` to rust-lang/stdarch@18ca8c5.

Created using https://github.com/rust-lang/josh-sync.

r? @ghost
…l, r=petrochenkov

delegation: remove method call generation

This PR removes method call generation from delegations, now we always generate default call. Part of rust-lang#118212.

We reuse methods probing engine for finding needed adjustments, thus extending number of supported cases. In this PR adjustments are applied to trait methods (was supported before) ~and static functions (new feature)~. Free functions can be supported later.

Finally this PR solves issues from parent generics propagation from rust-lang#155906.

r? @petrochenkov
rustc_on_unimplemented: introduce format specifiers

...as printing options for the annotated item.

See also the test and dev guide prose. This only affects rustc_on_unimplemented, not (yet) the other diagnostic attributes. I plan to do that in some later PR.

```rust
#![feature(rustc_attrs)]

#[rustc_on_unimplemented(
    message = "normal: {This}, path: {This:path},  resolved: {This:resolved}"
)]
pub trait Trait<'lifetime, const CONST_GENERIC: usize, A, B> where A: Send {}
```
will do:
```
normal: Trait, path: Trait<'lifetime, CONST_GENERIC, A, B>,  resolved: Trait<'_, 6, u8, _>
```
…=oli-obk

fix E0371 description

This changes the `impl`s to be `impl {Trait} for dyn {Trait}` instead of just `impl {Trait} for {Trait}` in the description of E0371.

(While this was not part of "Crafting errors like rustc" workshop at RustWeek by @jdonszelmann and @estebank, I found this while going through all errors Rust emits to pick a favourite)
tidy: remove duplicate entry and alphabetize OS constants list
…i-obk

Drop skip_move_check_fns query.

Looking at the header of the impl block for each method can be just as fast.
fix breakpoint callback registration in `lldb_batchmode`

We'd been failing to register the callback for a while now, because it couldn't find the specified function. This change imports `lldb_batchmode` and uses the namespaced name of the function.

As an aside, I'm relatively sure this breakpoint callback isn't necessary anymore. Whenever lldb stops at a breakpoint, it updates the selected thread/frame automatically. I don't want to remove it quite yet because I *might* need it for some bookkeeping with the `lldb-repr` directive (and `--bless` behavior)
@rust-bors rust-bors Bot added the rollup A PR which is a rollup label May 26, 2026
@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) A-rustc-dev-guide Area: rustc-dev-guide S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 26, 2026
@JonathanBrouwer
Copy link
Copy Markdown
Contributor Author

@bors r+ rollup=never p=5

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 26, 2026

📌 Commit 6140aee has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 26, 2026
@jhpratt
Copy link
Copy Markdown
Member

jhpratt commented May 26, 2026

GitHub Actions currently failing to queue anything. Let's avoid potentially confusing bors. See GitHub status for updates.

@bors treeclosed=100

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 26, 2026

Tree closed for PRs with priority less than 100.

@jhpratt
Copy link
Copy Markdown
Member

jhpratt commented May 26, 2026

Supposedly mitigated

@bors treeclosed-

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 26, 2026

Tree is now open for merging.

@rust-bors

This comment has been minimized.

@rust-bors rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 26, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 26, 2026

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 3h 10m 32s
Pushing b4fefcd to main...

@rust-bors rust-bors Bot merged commit b4fefcd into rust-lang:main May 26, 2026
1 check passed
@rustbot rustbot added this to the 1.98.0 milestone May 26, 2026
@rust-timer
Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#156161 rustc_on_unimplemented: introduce format specifiers b6e56cbf4aebb9a321c101e84e10598f3e1782da (link)
#156541 delegation: remove method call generation e5cdaec677ac2ad09a30236ad4034b65385cbba7 (link)
#156752 fix E0371 description 94bec2db1408e3c4d3a01798d954d52f4597cbfe (link)
#156761 tidy: remove duplicate entry and alphabetize OS constants l… 04c94f3f2dab8a55a099a83bef0d0458929aeac3 (link)
#156872 Drop skip_move_check_fns query. 6be94f6e855544b17b4a243bdf6c86a3ceeb7a2a (link)
#156899 fix breakpoint callback registration in lldb_batchmode c8b22a37f0348cc3c66e3ca220aa4d7bca399658 (link)
#156927 Reorganize tests/ui/issues [1/N] 81f295e821ef63094a871d8cbd4695a5238cd322 (link)
#156947 Update mdbook to 0.5.3 2c393d96570906b3e24e29f3c4a42a3621d621cf (link)
#156959 stdarch subtree update 56ae0d37919546f14574e9040bb83780cba005cd (link)

previous master: b7e97a98f2

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions
Copy link
Copy Markdown
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing b7e97a9 (parent) -> b4fefcd (this PR)

Test differences

Show 69 test diffs

Stage 1

  • [ui] tests/ui/coercion/fn-item-to-dyn-any.rs: [missing] -> pass (J1)
  • [ui] tests/ui/cross-crate/dyn-trait-lifetime-infer-metadata.rs: [missing] -> pass (J1)
  • [ui] tests/ui/delegation/self-coercion-errors.rs: [missing] -> pass (J1)
  • [ui] tests/ui/delegation/self-coercion-static-free.rs: [missing] -> pass (J1)
  • [ui] tests/ui/deprecation/deprecated-unstable-method-in-staged-api.rs: [missing] -> pass (J1)
  • [ui] tests/ui/drop/drop-in-for-loop-destructure.rs: [missing] -> pass (J1)
  • [ui] tests/ui/inference/need_type_info/unconstrained-type-in-closure.rs: [missing] -> pass (J1)
  • [ui] tests/ui/issues/issue-16922-rpass.rs: pass -> [missing] (J1)
  • [ui] tests/ui/issues/issue-17121.rs: pass -> [missing] (J1)
  • [ui] tests/ui/issues/issue-17216.rs: pass -> [missing] (J1)
  • [ui] tests/ui/issues/issue-17337.rs: pass -> [missing] (J1)
  • [ui] tests/ui/issues/issue-17551.rs: pass -> [missing] (J1)
  • [ui] tests/ui/issues/issue-17662.rs: pass -> [missing] (J1)
  • [ui] tests/ui/issues/issue-17800.rs: pass -> [missing] (J1)
  • [ui] tests/ui/issues/issue-17904-2.rs: pass -> [missing] (J1)
  • [ui] tests/ui/issues/issue-17904.rs: pass -> [missing] (J1)
  • [ui] tests/ui/issues/issue-17954.rs: pass -> [missing] (J1)
  • [ui] tests/ui/on-unimplemented/format_specs.rs: [missing] -> pass (J1)
  • [ui] tests/ui/regions/relate-bound-region-in-method-return.rs: [missing] -> pass (J1)
  • [ui] tests/ui/structs-enums/tuple-variant-as-struct-variant.rs: [missing] -> pass (J1)
  • [ui] tests/ui/thread-local/thread-local-borrow-past-function-end.rs: [missing] -> pass (J1)
  • [ui] tests/ui/where-clauses/where-clause-on-struct-definitions.rs: [missing] -> pass (J1)
  • [ui] tests/ui/where-clauses/where-clause-on-unit-struct.rs: [missing] -> pass (J1)

Stage 2

  • [ui] tests/ui/coercion/fn-item-to-dyn-any.rs: [missing] -> pass (J0)
  • [ui] tests/ui/cross-crate/dyn-trait-lifetime-infer-metadata.rs: [missing] -> pass (J0)
  • [ui] tests/ui/delegation/self-coercion-errors.rs: [missing] -> pass (J0)
  • [ui] tests/ui/delegation/self-coercion-static-free.rs: [missing] -> pass (J0)
  • [ui] tests/ui/deprecation/deprecated-unstable-method-in-staged-api.rs: [missing] -> pass (J0)
  • [ui] tests/ui/drop/drop-in-for-loop-destructure.rs: [missing] -> pass (J0)
  • [ui] tests/ui/inference/need_type_info/unconstrained-type-in-closure.rs: [missing] -> pass (J0)
  • [ui] tests/ui/issues/issue-16922-rpass.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-17121.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-17216.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-17337.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-17551.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-17662.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-17800.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-17904-2.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-17904.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-17954.rs: pass -> [missing] (J0)
  • [ui] tests/ui/on-unimplemented/format_specs.rs: [missing] -> pass (J0)
  • [ui] tests/ui/regions/relate-bound-region-in-method-return.rs: [missing] -> pass (J0)
  • [ui] tests/ui/structs-enums/tuple-variant-as-struct-variant.rs: [missing] -> pass (J0)
  • [ui] tests/ui/thread-local/thread-local-borrow-past-function-end.rs: [missing] -> pass (J0)
  • [ui] tests/ui/where-clauses/where-clause-on-struct-definitions.rs: [missing] -> pass (J0)
  • [ui] tests/ui/where-clauses/where-clause-on-unit-struct.rs: [missing] -> pass (J0)

Additionally, 23 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard b4fefcd60bfd770510f7dc540e887dd3ba4fe5c1 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. optional-x86_64-gnu-parallel-frontend: 2h 39m -> 1h 43m (-35.1%)
  2. dist-apple-various: 1h 32m -> 1h 59m (+28.8%)
  3. dist-powerpc64-linux-musl: 1h 16m -> 1h 35m (+24.1%)
  4. x86_64-msvc-2: 2h 30m -> 1h 55m (-23.1%)
  5. dist-powerpc64-linux-gnu: 1h 16m -> 1h 33m (+21.6%)
  6. dist-x86_64-mingw: 2h 35m -> 2h 5m (-19.1%)
  7. dist-x86_64-apple: 1h 44m -> 2h (+15.8%)
  8. pr-check-1: 30m 13s -> 34m 28s (+14.0%)
  9. x86_64-gnu-llvm-22-2: 1h 30m -> 1h 19m (-12.7%)
  10. test-various: 2h 6m -> 2h 18m (+9.7%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (b4fefcd): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.2% [0.1%, 0.2%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary 2.6%, secondary -3.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
4.2% [2.9%, 6.2%] 3
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.0% [-2.0%, -2.0%] 1
Improvements ✅
(secondary)
-3.4% [-7.3%, -2.0%] 6
All ❌✅ (primary) 2.6% [-2.0%, 6.2%] 4

Cycles

Results (primary 3.4%, secondary -0.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
3.4% [2.3%, 5.3%] 4
Regressions ❌
(secondary)
2.2% [2.2%, 2.2%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.7% [-2.7%, -2.7%] 1
All ❌✅ (primary) 3.4% [2.3%, 5.3%] 4

Binary size

Results (secondary 0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.0% [0.0%, 0.0%] 6
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Bootstrap: 511.751s -> 518.746s (1.37%)
Artifact size: 400.67 MiB -> 400.67 MiB (-0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) A-rustc-dev-guide Area: rustc-dev-guide merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.