minor improvement to Rc docs to avoid use of unwrap #15697
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
There was a problem hiding this comment.
I believe this example is showing how it is known for a fact that gadget_opt, while a weak pointer, is known to have at least one strong pointer floating around. I'm also not sure that map is the best way to handle options, but rather a match with a None case instead. In general map is used to produce Option<U> from Option<T>, but in this case it's being used in a more iterative context.
Contributor
Author
There was a problem hiding this comment.
Fair enough! It was suggested on reddit that unwrap should be avoided in general, and that using map was preferable. I'm happy to just close this to be honest.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Nov 28, 2025
Fixes rust-lang/rust-clippy#15404 changelog: [`result_large_err`]: Add `large_error_ignored` configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.