Skip to content

interpret/validity: properly treat zero-variant enums so that we do not have to check layout.is_uninhabited#156988

Open
RalfJung wants to merge 1 commit into
rust-lang:mainfrom
RalfJung:validate-uninhabited
Open

interpret/validity: properly treat zero-variant enums so that we do not have to check layout.is_uninhabited#156988
RalfJung wants to merge 1 commit into
rust-lang:mainfrom
RalfJung:validate-uninhabited

Conversation

@RalfJung
Copy link
Copy Markdown
Member

I am very happy to finally remove the last of these somewhat ad-hoc checks. :)

r? @oli-obk

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 26, 2026

Some changes occurred to the CTFE machinery

cc @oli-obk, @lcnr

The Miri subtree was changed

cc @rust-lang/miri

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 26, 2026
Copy link
Copy Markdown
Contributor

@oli-obk oli-obk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 27, 2026

📌 Commit e724fa6 has been approved by oli-obk

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 27, 2026
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request May 27, 2026
…li-obk

interpret/validity: properly treat zero-variant enums so that we do not have to check layout.is_uninhabited

I am very happy to finally remove the last of these somewhat ad-hoc checks. :)

r? @oli-obk
rust-bors Bot pushed a commit that referenced this pull request May 27, 2026
Rollup of 8 pull requests

Successful merges:

 - #156970 (coverage: Use original HIR info for synthetic by-move coroutine bodies)
 - #156390 (Constify Iterator-related methods and functions)
 - #156401 (rustdoc: deterministic sorting for `doc_cfg` badges)
 - #156845 (Clarify "infinite size" in cyclic-type diagnostic refers to the type name)
 - #156973 (Add uwtable annotation to modules when required)
 - #156985 (Limit the additional DLL to Windows)
 - #156988 (interpret/validity: properly treat zero-variant enums so that we do not have to check layout.is_uninhabited)
 - #157002 (std: Fix thread::available_parallelism on Redox targets)
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request May 27, 2026
…li-obk

interpret/validity: properly treat zero-variant enums so that we do not have to check layout.is_uninhabited

I am very happy to finally remove the last of these somewhat ad-hoc checks. :)

r? @oli-obk
rust-bors Bot pushed a commit that referenced this pull request May 27, 2026
Rollup of 10 pull requests

Successful merges:

 - #156970 (coverage: Use original HIR info for synthetic by-move coroutine bodies)
 - #157022 (MIR inlining: allow backends to opt-in to inlining intrinsics)
 - #157026 (miri subtree update)
 - #156390 (Constify Iterator-related methods and functions)
 - #156845 (Clarify "infinite size" in cyclic-type diagnostic refers to the type name)
 - #156955 (Fix const-eval of shared generic reborrows)
 - #156973 (Add uwtable annotation to modules when required)
 - #156985 (Limit the additional DLL to Windows)
 - #156988 (interpret/validity: properly treat zero-variant enums so that we do not have to check layout.is_uninhabited)
 - #157002 (std: Fix thread::available_parallelism on Redox targets)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants