Avoid mono collection hangs from recursive type growth#156993
Open
naganohara-yoshino wants to merge 2 commits into
Open
Avoid mono collection hangs from recursive type growth#156993naganohara-yoshino wants to merge 2 commits into
naganohara-yoshino wants to merge 2 commits into
Conversation
Collaborator
|
rustbot has assigned @dingxiangfei2009. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
Author
|
With this change, the code now terminates and reports the recursion-limit diagnostic: #![allow(dead_code)]
enum Foo<A> {
Fst,
Snd(Box<dyn Fn() -> Foo<(A, A)>>),
}
fn recursive<A>(x: Foo<A>) {
match x {
Foo::Fst => (),
Foo::Snd(f) => recursive(f()),
}
}
fn main() {
let p0: Foo<()> = Foo::Fst;
recursive(p0);
}UI test is added accordingly. |
Collaborator
|
This PR modifies |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The mono item collector currently detects infinite recursive monomorphization
with a depth-based recursion limit. This can be too late for non-regular
recursive instantiations, where each recursive step produces much larger
instance arguments.
This PR starts checking the structural length of
instance.argsonce recursiveinstantiation is partway to the recursion limit. If the arguments already exceed
the type length limit, rustc emits the recursion limit diagnostic instead of continuing to process enormous types.
This keeps the diagnostic consistent with the error produced when the same code
is compiled with a smaller
#![recursion_limit].Related Issue
Fixes #156272.