Skip to content

Allow building the source tarballs while offline#157014

Open
bjorn3 wants to merge 1 commit into
rust-lang:mainfrom
bjorn3:source_tarball_offline
Open

Allow building the source tarballs while offline#157014
bjorn3 wants to merge 1 commit into
rust-lang:mainfrom
bjorn3:source_tarball_offline

Conversation

@bjorn3
Copy link
Copy Markdown
Member

@bjorn3 bjorn3 commented May 27, 2026

Previously locally vendored dependencies wouldn't be reused when building the source tarball, instead everything would be downloaded from the internet again (if not in the cargo cache).

Fixes #156982

Previously locally vendored dependencies wouldn't be reused when
building the source tarball, instead everything would be downloaded from
the internet again (if not in the cargo cache).
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels May 27, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 27, 2026

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: bootstrap
  • bootstrap expanded to 6 candidates
  • Random selection from Mark-Simulacrum, clubby789, jieyouxu

@bjorn3 bjorn3 added the beta-nominated Nominated for backporting to the compiler in the beta channel. label May 27, 2026
@bjorn3
Copy link
Copy Markdown
Member Author

bjorn3 commented May 27, 2026

Nominating for beta backport as #156196 will break distros that build rustc offline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-bootstrap-vendoring beta-nominated Nominated for backporting to the compiler in the beta channel. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nighly no longer builds offline, fails in Vendoring sources to...

3 participants