LivenessValues: use Either rather than mutually exclusive Options#157035
Open
amandasystems wants to merge 1 commit into
Open
LivenessValues: use Either rather than mutually exclusive Options#157035amandasystems wants to merge 1 commit into
LivenessValues: use Either rather than mutually exclusive Options#157035amandasystems wants to merge 1 commit into
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @jackh726 rustbot has assigned @jackh726. Use Why was this reviewer chosen?The reviewer was selected based on:
|
rustbot
added
S-waiting-on-author
amandasystems
force-pushed
the
region-values-either
branch
from
a5b704b to
04c1272
Compare
amandasystems
force-pushed
the
region-values-either
branch
from
04c1272 to
e8beadf
Compare
rustbot
added
S-waiting-on-review
Contributor
Author
|
Sorry, read through the diff AGAIN and of course noticed a few mistakes I hadn't seen in the terminal window. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was reading through
LivenessValuesand realised it had a lot of comments explaining that twoOptions were mutually exclusive, plus some redundant logic to handle this.This is a drive-by fix to use an
Eitherinstead, which makes that property obvious from the code. It also removes the repeated logic.