LLVM 23: Run AssignGUIDPass in some places#157055
Open
TimNN wants to merge 1 commit into
Open
Conversation
rustbot
added
A-LLVM
Collaborator
|
r? @cuviper rustbot has assigned @cuviper. Use Why was this reviewer chosen?The reviewer was selected based on:
|
rustbot
added
the
llvm-main
rustbot
added
S-waiting-on-author
Contributor
Author
|
Some FileCheck tests also need to be updated since the generated IR can now include |
Collaborator
|
Some changes occurred in tests/codegen-llvm/sanitizer cc @rcvalle |
rustbot
added
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
llvm/llvm-project#184065 introduced the new pass.
I'm not 100% confident that this is the correct patch, but it makes all the previously failing
run-make"lto" tests pass on my machine.I added the pass to the
if (NeedThinLTOBufferPasses)section to match theaddRequiredLTOPreLinkPasseschanges from the LLVM PR, and to theLLVMRustModuleSerializesection based on the stack trace of an LLVM assertion.The IR may now contain an additional
!guidattribute, requiring some codegen test expectations to be updated. I mostly followed the pattern from the LLVM PR, and removed trailing{s. (For both, tests that were failing locally, as well as potentially problematic expectations identified via grep, in case the test wasn't being run locally).@rustbot label llvm-main