Rollup of 4 pull requests#157061
Closed
GuillaumeGomez wants to merge 10 commits into
Closed
Conversation
…=GuillaumeGomez rustdoc: deterministic sorting for `doc_cfg` badges Fixes rust-lang#156391 Currently, target-exclusive `doc_cfg` badges (eg. "Available on...") reuse the order of predicates as they appear in the source code. This often buries popular targets behind niche ones and leads to inconsistent UI rendering. This PR introduces a deterministic sorting mechanism to the `Cfg` AST prior to HTML/JSON rendering. **Note for Reviewers:** To provide the best UX, I implemented a lightweight tiering heuristic (prioritizing major platforms like Linux/Apple/Windows first, followed by mobile, then BSDs, and alphabetizing the rest). However, I am completely open to tweaking these priority groupings or falling back to a different sorting logic if the team prefers. Let me know what you think!
cg_llvm: Use `LLVMDIBuilderCreateEnumeratorOfArbitraryPrecision` - Part of rust-lang#134001 - Follow-up to rust-lang#146763 --- This PR replaces our custom `LLVMRustDIBuilderCreateEnumerator` FFI binding with an equivalent LLVM-C binding to `LLVMDIBuilderCreateEnumeratorOfArbitraryPrecision`, which was introduced in LLVM 21. I have also added comments to the remaining `LLVMRustDIBuilder` functions explaining why they currently can't use an LLVM-C binding, and noted some other functions that can use LLVM-C bindings in the future.
…suggestion-144319, r=jieyouxu Suggest function-local constructors without enclosing function path Closes rust-lang#144319 This fixes a mismatched-type wrapper suggestion for constructors defined inside function-like scopes. The previous diagnostic used `def_path_str` directly, so a function-local tuple struct could be suggested as `main::Foo(false)`, even though `main` is not a module path that can name the constructor. The suggestion now prints the constructor path under rustc's existing suggestion printer mode. That mode omits path segments that cannot be written in source, while preserving real path segments such as local modules and enum names. The regression test covers: - a function-local tuple struct constructor - a function-local enum variant - a tuple struct inside a function-local module - a tuple struct inside a closure body - a tuple struct inside an inline const block
Fix missing note of escaping `{` for braces including whitespaces
Fixes rust-lang#156868
Add note of escaping `{` for braces including whitespaces
rustbot
added
A-LLVM
Member
Author
|
@bors r+ rollup=never p=5 |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
May 28, 2026
Rollup of 4 pull requests Successful merges: - #156401 (rustdoc: deterministic sorting for `doc_cfg` badges) - #156746 (cg_llvm: Use `LLVMDIBuilderCreateEnumeratorOfArbitraryPrecision`) - #156889 (Suggest function-local constructors without enclosing function path) - #157012 (Fix missing note of escaping `{` for braces including whitespaces)
rust-bors
Bot
added
S-waiting-on-review
Contributor
|
💔 Test for 6b9bc8c failed: CI. Failed job:
|
Contributor
|
Spurious. Closing in favour of bigger rollup |
rust-bors
Bot
added
the
S-waiting-on-author
rustbot
removed
the
S-waiting-on-review
Contributor
|
This pull request was unapproved due to being closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
doc_cfgbadges #156401 (rustdoc: deterministic sorting fordoc_cfgbadges)LLVMDIBuilderCreateEnumeratorOfArbitraryPrecision#156746 (cg_llvm: UseLLVMDIBuilderCreateEnumeratorOfArbitraryPrecision){for braces including whitespaces #157012 (Fix missing note of escaping{for braces including whitespaces)r? @ghost
Create a similar rollup