Skip to content

Add regression test for issue #144888#157131

Open
pbkx wants to merge 1 commit into
rust-lang:mainfrom
pbkx:issue-144888-ui-test
Open

Add regression test for issue #144888#157131
pbkx wants to merge 1 commit into
rust-lang:mainfrom
pbkx:issue-144888-ui-test

Conversation

@pbkx
Copy link
Copy Markdown

@pbkx pbkx commented May 30, 2026

Issue #144888 is labeled E-needs-test for an ICE involving unhandled node Crate(Mod).

This adds a focused UI regression test for the reduced example. The test is compile-fail, checks the current non-ICE diagnostics, and avoids the unrelated missing-main diagnostic by compiling as a library.

Fixes #144888.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 30, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 30, 2026

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 17 candidates

@rustbot

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@pbkx pbkx force-pushed the issue-144888-ui-test branch from 27fe31d to 73765b4 Compare May 30, 2026 00:53
@rustbot

This comment has been minimized.

@pbkx pbkx force-pushed the issue-144888-ui-test branch 2 times, most recently from 642b817 to a6df11a Compare May 30, 2026 16:27
@rust-log-analyzer

This comment has been minimized.

@pbkx pbkx force-pushed the issue-144888-ui-test branch from a6df11a to 55cb982 Compare May 30, 2026 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ICE: unhandled node Crate(Mod

4 participants