Expose an API for polymorphic drop glue translation#157156
Open
Nadrieril wants to merge 4 commits into
Open
Conversation
Collaborator
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
Collaborator
|
rustbot has assigned @JonathanBrouwer. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
Member
Author
|
Wait why on earth would this be backend-dependent 🤔 |
Member
Author
|
Investigation reveals some rather broken state of affairs: calling |
Member
|
I'm not sure if these situations are interesting for cg_gcc maintainers, but just to make sure - CC @rust-lang/wg-gcc-backend |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At my $dayjob I work on a rustc driver called Charon, whose main selling point is its ability to accurately represent polymorphic Rust code. In adding support for drops I ran into an issue: the code that generates drop glue shim expects monomorphized types and ICEs when used in some polymorphic contexts. Example output:
I recall a Zulip discussion about this but cannot find it.
This PR exposes
build_drop_shimand gives it aTypingEnvargument, for use in rustc drivers like mine.Disclosure: I used LLM assistance to make this very complicated PR. This consisted in me repeatedly telling it to do something simpler until I eventually cleaned it up myself. I like the test it wrote tho.