Rollup of 4 pull requests#157219
Merged
Merged
Conversation
directory handles: add Dir::metadata Adds a `metadata` method to the `fs::Dir` type so that one can fetch the metadata of a directory directly from a handle. This is very similar to `File::metadata`. In fact we reuse the existing implementation, which reduces code duplication but also is a bit hacky. r? @the8472 Tracking issue: rust-lang#120426
…nket, r=lolbinarycat rustdoc: Separate the caches for synthetic auto trait & blanket impls Fixes rust-lang#148980.
Don't lower `inner_span` multiple times
…g, r=Nadrieril use custom `Exhaustive` enum instead of `bool` Small cleanup, boolean blindness and all that. I'm not totally sure about where to put the `RefutableFlag` enum, but the current place seemed fine. r? Nadrieril (based on pattern match desugaring expertise)
rustbot
added
A-attributes
Member
Author
|
@bors r+ rollup=never p=5 |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors
Bot
added
merged-by-bors
Contributor
Collaborator
|
📌 Perf builds for each rolled up PR:
previous master: 39e7b2ae75 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 39e7b2a (parent) -> 14210df (this PR) Test differencesShow 236 test diffsStage 1
Stage 2
Additionally, 232 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 14210df0e27ccd7d9e6a05b8085cbd438e4bbc65 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
This was referenced May 31, 2026
Collaborator
|
Finished benchmarking commit (14210df): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -1.8%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesThis perf run didn't have relevant results for this metric. Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 514.753s -> 511.515s (-0.63%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
inner_spanmultiple times #157185 (Don't lowerinner_spanmultiple times)Exhaustiveenum instead ofbool#157211 (use customExhaustiveenum instead ofbool)r? @ghost
Create a similar rollup