Skip to content

Add experimental unnamed_enum_variants feature gate#157274

Open
kupiakos wants to merge 1 commit into
rust-lang:mainfrom
kupiakos:open-enums-feature-gate
Open

Add experimental unnamed_enum_variants feature gate#157274
kupiakos wants to merge 1 commit into
rust-lang:mainfrom
kupiakos:open-enums-feature-gate

Conversation

@kupiakos
Copy link
Copy Markdown
Contributor

@kupiakos kupiakos commented Jun 1, 2026

This parses the basic syntax and defines a feature gate for the unnamed enum variants lang experiment, tracking issue #156628.

cc @joshtriplett, @scottmcm, @tmandry

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Jun 1, 2026

The parser was modified, potentially altering the grammar of (stable) Rust
which would be a breaking change.

cc @fmease

rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.

cc @rust-lang/rust-analyzer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rust-analyzer Relevant to the rust-analyzer team, which will review and decide on the PR/issue. labels Jun 1, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Jun 1, 2026

r? @Kivooeo

rustbot has assigned @Kivooeo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 17 candidates

Copy link
Copy Markdown
Contributor

@ChayimFriedman2 ChayimFriedman2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please separate the rust-analyzer changes into a PR for rust-lang/rust-analyzer.

View changes since this review

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 1, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Jun 1, 2026

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@kupiakos
Copy link
Copy Markdown
Contributor Author

kupiakos commented Jun 1, 2026

I've opened a PR for the rust-analyzer bits and will rebase this PR once those changes are pushed over to rust-lang/rust.

In the meantime, the rest of the PR should be able to receive feedback as-is.

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 1, 2026
@ChayimFriedman2
Copy link
Copy Markdown
Contributor

ChayimFriedman2 commented Jun 1, 2026

You can remove the r-a changes from this PR. The other changes are not dependent on them. And also, I don't want to merge the r-a PR until the rustc PR is merged.

@kupiakos kupiakos force-pushed the open-enums-feature-gate branch from e39a747 to e6b4102 Compare June 1, 2026 22:01
@kupiakos
Copy link
Copy Markdown
Contributor Author

kupiakos commented Jun 1, 2026

@ChayimFriedman2 Ah, I'd mistakenly thought that the r-a parser was actually being utilized by rustc here based on the rustc dev guide. But indeed this change isn't dependent on r-a. I've removed the r-a bits from this PR entirely as requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rust-analyzer Relevant to the rust-analyzer team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants