std tests: avoid duplicating thread-local machinery#157416
Open
RalfJung wants to merge 1 commit into
Open
Conversation
Collaborator
|
r? @clarfonthey rustbot has assigned @clarfonthey. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
d9f4393 to
316f09f
Compare
Contributor
|
Duplicating libstd in tests was probably bound to do something like this eventually, honestly. The code looks fine and I guess while it's tempting to find a permanent fix I feel more inclined to just merge as a direct improvement. r=me from the libs side but will let you tell bors to merge in case you wanted more input on the review first. Your comment implies no, but since this is sufficiently weird and you have r+ permissions anyway I think it's fine to let you do it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under
cfg(test)we have two copies of the standard library loaded, including two copies of all its global variables. Something about how that interacts with #148799 results in memory leaks on windows-gnu targets, which are caught by Miri.I'm not sure if it's worth debugging this. It's easier to just avoid duplicating the thread-local machinery.
(This is something we had already done in the past, and then at some point stopped doing as Miri showed no more problems with the duplicate machinery. Now the problems are back.)
Cc @joboet @ChrisDenton