Fix parser error recovery treating 'dyn' as a strict keyword in Rust …#157577
Open
Willi0728 wants to merge 1 commit into
Open
Fix parser error recovery treating 'dyn' as a strict keyword in Rust …#157577Willi0728 wants to merge 1 commit into
Willi0728 wants to merge 1 commit into
Conversation
…2015 when used in `dyn + dyn`
Collaborator
|
The parser was modified, potentially altering the grammar of (stable) Rust cc @fmease |
Collaborator
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nnethercote (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
Why was this reviewer chosen?The reviewer was selected based on:
|
Author
|
@rustbot label +relnotes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…2015 when used in
dyn + dynFixes: #157565
Description
A diagnostics improvement #84896 in 2015 edition caused errors when
dyn + dynwas used, even thoughdynis a contextual keyword in the 2015 edition.Solution
A check was added in
rustc_parse/src/parser/ty.rs:1095:This checks that the version is not 2015 before throwing an error.
A regression test was also added, in
tests/ui/parser/dyn-2015-identifier.rs