test: remove ineffective link-extern-crate-with-drop-type test#157596
Open
arshalaromal wants to merge 1 commit into
Open
test: remove ineffective link-extern-crate-with-drop-type test#157596arshalaromal wants to merge 1 commit into
arshalaromal wants to merge 1 commit into
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @oli-obk (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
Why was this reviewer chosen?The reviewer was selected based on:
|
Contributor
|
@bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jun 8, 2026
…st, r=JonathanBrouwer test: remove ineffective link-extern-crate-with-drop-type test Closes rust-lang#157477 Removed `tests/ui/cross-crate/link-extern-crate-with-drop-type.rs` and its auxiliary file. As discussed in the issue, this test was meant for language-level "resources" which were removed from Rust long ago, making the current test ineffective. Verified locally that the remaining tests in `tests/ui/cross-crate` pass successfully.
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jun 8, 2026
…st, r=JonathanBrouwer test: remove ineffective link-extern-crate-with-drop-type test Closes rust-lang#157477 Removed `tests/ui/cross-crate/link-extern-crate-with-drop-type.rs` and its auxiliary file. As discussed in the issue, this test was meant for language-level "resources" which were removed from Rust long ago, making the current test ineffective. Verified locally that the remaining tests in `tests/ui/cross-crate` pass successfully.
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 8, 2026
…uwer Rollup of 13 pull requests Successful merges: - #147302 (asm! support for the Xtensa architecture) - #148820 (Add very basic "comptime" fn implementation) - #157299 (Fix unstable diagnostics in tests) - #143511 (Improve TLS codegen by marking the panic/init path as cold) - #154608 (Add `_value` API for number literals in proc-macro) - #156762 (xfs support in `test_rename_directory_to_non_empty_directory`) - #157300 (Relax test requirements for consistency) - #157383 (tests: codegen-llvm: Ignore BPF targets in c-variadic-opt) - #157413 (fix: don't suggest .into_iter() for .cloned()/.copied() on non-reference Option) - #157578 (Fix diagnostics for non-exhaustive destructuring assignments (#157553)) - #157587 (explain that the size_of constant also serves to avoid optimizing away 'unused' size_of calls) - #157596 (test: remove ineffective link-extern-crate-with-drop-type test) - #157602 (rustdoc: Remove unnecessary fast path)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #157477
Removed
tests/ui/cross-crate/link-extern-crate-with-drop-type.rsand its auxiliary file. As discussed in the issue, this test was meant for language-level "resources" which were removed from Rust long ago, making the current test ineffective.Verified locally that the remaining tests in
tests/ui/cross-cratepass successfully.