Emit error for unused target expression in glob delegations#157601
Open
aerooneqq wants to merge 1 commit into
Open
Emit error for unused target expression in glob delegations#157601aerooneqq wants to merge 1 commit into
aerooneqq wants to merge 1 commit into
Conversation
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
aerooneqq
force-pushed
the
delegation-glob-useless-target-expr-error
branch
from
e6b6c5e to
c967907
Compare
aerooneqq
commented
Jun 8, 2026
| tcx.ensure_done().lower_delayed_owner(id); | ||
| } | ||
|
|
||
| tcx.check_unused_target_exprs_in_glob_delegations(&krate.delayed_ids); |
Contributor
Author
There was a problem hiding this comment.
Considering that this function (force_delayed_owners_lowering) may not exist after possible incremental lowering PR merge maybe there is a better place for this diagnostic (maybe there is a better place regardless incremental lowering PR). The only benefit of the current placement that I see is that delegation-related errors are mostly grouped together in rustc_ast_lowering::errors, but we can move it to rustc_hir_analysis for example where it belongs more naturally?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR emits error if unuse target expression is specified for glob delegation. Second part of #156798.
Part of #118212.
r? @petrochenkov