Skip to content

Implement proc_macro_set_group_span#158626

Open
Noratrieb wants to merge 1 commit into
rust-lang:mainfrom
Noratrieb:proc_macro_set_group_span
Open

Implement proc_macro_set_group_span#158626
Noratrieb wants to merge 1 commit into
rust-lang:mainfrom
Noratrieb:proc_macro_set_group_span

Conversation

@Noratrieb

Copy link
Copy Markdown
Member

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 30, 2026
@rustbot

rustbot commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

r? @adwinwhite

rustbot has assigned @adwinwhite.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 17 candidates

@petrochenkov

Copy link
Copy Markdown
Contributor

Open and close delimiter spans must have the same SyntaxContext, this is more or less the same invariant as delimiters always being balanced.
This API shouldn't break it, we need to panic at some point if a group got inconsistent delimiter spans.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants