Skip to content

First steps of late-bound turbofishing (place FnDef behind a dummy binder)#158632

Draft
addiesh wants to merge 6 commits into
rust-lang:mainfrom
addiesh:superfisher
Draft

First steps of late-bound turbofishing (place FnDef behind a dummy binder)#158632
addiesh wants to merge 6 commits into
rust-lang:mainfrom
addiesh:superfisher

Conversation

@addiesh

@addiesh addiesh commented Jun 30, 2026

Copy link
Copy Markdown

r? oli-obk

This PR is part of #156581. This should be functionally identical to prior behavior, with the added fact that FnDef now places its arguments behind a binder.

most changes boil down to

  • replacing args from FnDef with args.no_bound_vars().unwrap()
  • replacing Ty::new_fn_def(/* ... */, args) with Ty::new_fn_def(/* ... */, ty::Binder::dummy(args))

@rustbot rustbot added the A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. label Jun 30, 2026
@rustbot

rustbot commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @oli-obk (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added PG-exploit-mitigations Project group: Exploit mitigations S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Jun 30, 2026

@addiesh addiesh Jul 1, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change has nothing to do with LLVM and as such should probably not have A-LLVM

View changes since the review

@addiesh

addiesh commented Jul 1, 2026

Copy link
Copy Markdown
Author

this PR probably shouldn't have as many tags as it does (A-LLVM, PG-exploit-mitigations, T-clippy, WG-trait-system-refactor)

@addiesh

addiesh commented Jul 1, 2026

Copy link
Copy Markdown
Author

@rustbot review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 1, 2026
@rustbot rustbot assigned BoxyUwU and unassigned oli-obk Jul 1, 2026
@rustbot

rustbot commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

boxyUwU is currently at their maximum review capacity.
They may take a while to respond.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@addiesh

addiesh commented Jul 1, 2026

Copy link
Copy Markdown
Author

rustbot removed oli, oops
r? BoxyUwU oli-obk

@rustbot

rustbot commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Requested reviewer is already assigned to this pull request.

Please choose another assignee.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. PG-exploit-mitigations Project group: Exploit mitigations S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants