Skip to content

Optimize ArrayChunks::try_rfold with DoubleEndedIterator::next_chunk_back#158704

Open
asder8215 wants to merge 1 commit into
rust-lang:mainfrom
asder8215:optimize_array_chunks
Open

Optimize ArrayChunks::try_rfold with DoubleEndedIterator::next_chunk_back#158704
asder8215 wants to merge 1 commit into
rust-lang:mainfrom
asder8215:optimize_array_chunks

Conversation

@asder8215

@asder8215 asder8215 commented Jul 2, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Since DoubleEndedIterator::next_chunk_back got merged in #156737, we can apply this method to optimize ArrayChunk::try_rfold.

I added @vinDelphini as a co-author because he was the one who originally made this change in his original PR on introducing DoubleEndedIterator::next_chunk_back.

@asder8215 @vinDelphini
Optimize ArrayChunks::try_rfold with DoubleEndedIterator::next_chunk_…
841041c 
…back

Co-authored-by: Vin <betadelphini.py@gmail.com>
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 2, 2026
@rustbot

rustbot commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

r? @aapoalas

rustbot has assigned @aapoalas.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: libs
  • libs expanded to 12 candidates
  • Random selection from 7 candidates

This was referenced Jul 2, 2026
Closed
Closed
aapoalas
aapoalas approved these changes Jul 3, 2026
View reviewed changes

@aapoalas aapoalas left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to get this simplified <3

View changes since this review

@aapoalas

aapoalas commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

@bors r+

@rust-bors

rust-bors Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 841041c has been approved by aapoalas

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 10. This pull request will be tested once the tree is reopened.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aapoalas aapoalas aapoalas approved these changes

Assignees

@aapoalas aapoalas

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@asder8215 @rustbot @aapoalas