Use IncreaseDepth::No for normalizes-to goal itself instead of its nested goals#158705
Use IncreaseDepth::No for normalizes-to goal itself instead of its nested goals#158705ShoyuVanilla wants to merge 1 commit into
IncreaseDepth::No for normalizes-to goal itself instead of its nested goals#158705Conversation
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Use `IncreaseDepth::No` for normalizes-to goal itself instead of its nested goals
This comment has been minimized.
This comment has been minimized.
25d5250 to
8c7b929
Compare
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (e3dd511): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf. @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (secondary -8.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 5.5%, secondary -16.5%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 485.944s -> 485.308s (-0.13%) |
|
r? lcnr |
| goal: Goal<I, I::Predicate>, | ||
| stalled_on: Option<GoalStalledOn<I>>, | ||
| increase_depth_for_nested: IncreaseDepthForNested, | ||
| increase_depth_for_nested: IncreaseDepth, |
There was a problem hiding this comment.
IncrementDepth and also rename the function argument name maybe 🤔 LowerAvailableDepth?
|
naming nit, otherwise r=me 😁 |
Might fix perf regressions in #157718 (comment)