Skip to content

Use IncreaseDepth::No for normalizes-to goal itself instead of its nested goals#158705

Open
ShoyuVanilla wants to merge 1 commit into
rust-lang:mainfrom
ShoyuVanilla:search-graph-depth-fixup
Open

Use IncreaseDepth::No for normalizes-to goal itself instead of its nested goals#158705
ShoyuVanilla wants to merge 1 commit into
rust-lang:mainfrom
ShoyuVanilla:search-graph-depth-fixup

Conversation

@ShoyuVanilla

@ShoyuVanilla ShoyuVanilla commented Jul 2, 2026

Copy link
Copy Markdown
Member

Might fix perf regressions in #157718 (comment)

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Jul 2, 2026
@ShoyuVanilla

Copy link
Copy Markdown
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 2, 2026
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Jul 2, 2026
Use `IncreaseDepth::No` for normalizes-to goal itself instead of its nested goals
@rust-log-analyzer

This comment has been minimized.

@ShoyuVanilla ShoyuVanilla force-pushed the search-graph-depth-fixup branch from 25d5250 to 8c7b929 Compare July 2, 2026 23:13
@rust-bors

rust-bors Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: e3dd511 (e3dd511562be8a5b2b1b46276fa6a16bffc1580f)
Base parent: c397dae (c397dae808f70caebab1fc4e11b3edf7e59f58c7)

@rust-timer

This comment has been minimized.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (e3dd511): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-37.3% [-37.5%, -37.1%] 3
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (secondary -8.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.8% [2.8%, 2.8%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-10.8% [-12.8%, -5.5%] 4
All ❌✅ (primary) - - 0

Cycles

Results (primary 5.5%, secondary -16.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
5.5% [5.5%, 5.5%] 1
Regressions ❌
(secondary)
2.9% [2.9%, 2.9%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-19.7% [-36.4%, -2.1%] 6
All ❌✅ (primary) 5.5% [5.5%, 5.5%] 1

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 485.944s -> 485.308s (-0.13%)
Artifact size: 393.37 MiB -> 393.33 MiB (-0.01%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 3, 2026
@ShoyuVanilla

Copy link
Copy Markdown
Member Author

r? lcnr
I was wrong and you were totally correct on this 😅

@ShoyuVanilla ShoyuVanilla marked this pull request as ready for review July 3, 2026 02:00
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 3, 2026
goal: Goal<I, I::Predicate>,
stalled_on: Option<GoalStalledOn<I>>,
increase_depth_for_nested: IncreaseDepthForNested,
increase_depth_for_nested: IncreaseDepth,

@lcnr lcnr Jul 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IncrementDepth and also rename the function argument name maybe 🤔 LowerAvailableDepth?

View changes since the review

@lcnr

lcnr commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

naming nit, otherwise r=me 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants