library: Make ProcThreadAttributeListBuilder more unsafe#158712
Open
workingjubilee wants to merge 1 commit into
Open
library: Make ProcThreadAttributeListBuilder more unsafe#158712workingjubilee wants to merge 1 commit into
ProcThreadAttributeListBuilder more unsafe#158712workingjubilee wants to merge 1 commit into
Conversation
rustbot
added
O-windows
Collaborator
|
|
workingjubilee
changed the title
windows::process::ProcThreadAttributeListBuilder more unsafeProcThreadAttributeListBuilder more unsafe
Member
|
This one I'll need to think a bit about. Honestly I've gone back and forth, though I fear this is ultimately a libs-api question. |
This comment has been minimized.
This comment has been minimized.
workingjubilee
force-pushed
the
make-procthreadattributelist-unsafer
branch
from
0ce091b to
6f0901e
Compare
Contributor
|
Having at least one marked |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Honestly, I took the "make it all
unsafe" approach in this draft because it wasn't clear to me what exactly was the best to do and I figured we'd find out in review.r? @ChrisDenton cc @PaulDance
Resolves #158601