Apply MCP 1003 and move diagnostics.rs into its own module#158732
Open
GuillaumeGomez wants to merge 2 commits into
Open
Apply MCP 1003 and move diagnostics.rs into its own module#158732GuillaumeGomez wants to merge 2 commits into
GuillaumeGomez wants to merge 2 commits into
Conversation
Collaborator
|
Some changes occurred in exhaustiveness checking cc @Nadrieril Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt Some changes occurred in compiler/rustc_attr_parsing |
rustbot
added
A-attributes
Collaborator
|
|
petrochenkov
reviewed
Jul 3, 2026
Contributor
There was a problem hiding this comment.
rust-lang/compiler-team#1003 (comment)
The result of the poll was to change the name of this file to
diagnostics/impls.rs
Member
Author
There was a problem hiding this comment.
Arf indeed. My bad.
Contributor
There was a problem hiding this comment.
This file is also diagnostics.rs (in the old meaning).
Member
Author
There was a problem hiding this comment.
I didn't change it here, it'll be part of another PR as it's far from being the only one.
… `error_helper.rs` into the `diagnostics` folder in `rustc_resolve`
GuillaumeGomez
force-pushed
the
rename-diagnostics
branch
from
b8a763f to
6942310
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #158699.
r? @JonathanBrouwer