Skip to content

Cache some data structures for debuginfo generation#158868

Draft
Kobzol wants to merge 1 commit into
rust-lang:mainfrom
Kobzol:debug-info-cache
Draft

Cache some data structures for debuginfo generation#158868
Kobzol wants to merge 1 commit into
rust-lang:mainfrom
Kobzol:debug-info-cache

Conversation

@Kobzol

@Kobzol Kobzol commented Jul 6, 2026

Copy link
Copy Markdown
Member

Opening for a perf. test.

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 6, 2026
@Kobzol

Kobzol commented Jul 6, 2026

Copy link
Copy Markdown
Member Author

@bors try @rust-timer queue

@rust-timer

Copy link
Copy Markdown
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 6, 2026
@rust-bors

rust-bors Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

⌛ Trying commit e6da08e with merge bd84d54

To cancel the try build, run the command @bors try cancel.

Workflow: https://github.com/rust-lang/rust/actions/runs/28805376096

rust-bors Bot pushed a commit that referenced this pull request Jul 6, 2026
Cache some data structures for debuginfo generation
@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

The job pr-check-2 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
249 | |                 ty::TypingEnv::fully_monomorphized(),
...   |
252 | |             &mut name,
253 | |         );
    | |_________- argument #4 of type `&mut HashSet<rustc_middle::ty::Ty<'_>, FxBuildHasher>` is missing
    |
note: function defined here
   --> compiler/rustc_codegen_ssa/src/debuginfo/type_names.rs:650:8
    |
650 | pub fn push_generic_args<'tcx>(
    |        ^^^^^^^^^^^^^^^^^
help: provide the argument
    |
246 |         type_names::push_generic_args(
...
252 |             &mut name,
253 ~             /* &mut HashSet<rustc_middle::ty::Ty<'_>, FxBuildHasher> */,
254 ~         );
    |

For more information about this error, try `rustc --explain E0061`.
[RUSTC-TIMING] rustc_codegen_cranelift test:false 1.248

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-perf Status: Waiting on a perf run to be completed. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants