Relax ExactSizeIterator requirement on size_hint. #24678
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
|
r? @aturon |
|
New rules require changes to the len method for Map, Zip, Inspect, Peek etc, all adaptors that impl ExactSizeIterator. |
Implement RFC 924. closes rust-lang/rfcs#924 [breaking-change]
Stebalien
force-pushed
the
rfc-924
branch
2 times, most recently
from
f036405 to
10232cb
Compare
The default implementation calls size_hint and we don't control the underlying iterator.
|
Good point. There's something wrong with my implementations so I'm closing this while I fix them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement yet-to-be-accepted rust-lang/rfcs#924. This is a breaking-change.