Properly highlight nested comments in vim#2749
Closed
bstrie wants to merge 1 commit intorust-lang:incomingfrom
Closed
Properly highlight nested comments in vim#2749bstrie wants to merge 1 commit intorust-lang:incomingfrom
bstrie wants to merge 1 commit intorust-lang:incomingfrom
Conversation
Prior to this commit, every block comment /* */ required two closing tags for every opening tag in order to terminate the highlighting. Setting and testing for a variable was the culprit, though I'm not certain why, but they appear to just be boilerplate lines from whatever pcwalton based this file upon. I've looked at other officially-distributed vim highlighting files and none seem to do the test that this commit removes, so I'm fairly certain it didn't provide anything vital. And now comment highlighting works!
Contributor
|
Integrated. Thanks! |
celinval
pushed a commit
to celinval/rust-dev
that referenced
this pull request
Jun 4, 2024
tshepang
added a commit
to tshepang/rust
that referenced
this pull request
Feb 24, 2026
all but one test suite support revisions directive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this commit, every block comment /* */ required two closing tags for
every opening tag in order to terminate the highlighting. Setting and testing
for a variable was the culprit, though I'm not certain why, but they appear to
just be boilerplate lines from whatever pcwalton based this file upon. I've
looked at other officially-distributed vim highlighting files and none seem to
do the test that this commit removes, so I'm fairly certain it didn't provide
anything vital. And now comment highlighting works!