Pretty-printer improvements#298
Closed
marijnh wants to merge 5 commits intorust-lang:masterfrom
marijnh:pp-comments
Closed
Pretty-printer improvements#298marijnh wants to merge 5 commits intorust-lang:masterfrom marijnh:pp-comments
marijnh wants to merge 5 commits intorust-lang:masterfrom
marijnh:pp-comments
Conversation
Contributor
Author
|
I guess you didn't merge this yet because it causes a failure. I've re-xfailed the offending test. That was supposed to be in the commits before, but somehow got lost. (How is a compile-fail test supposed to fail, anyway?) |
The patch also includes a number of smaller fixes to the pretty-printer that were encountered on the way.
Still not used, except by the pretty-printer.
This involved making ast.variant spanned.
Contributor
Author
|
Updated again to fix conflict with other patch. |
Contributor
|
Integrated. Sorry for the delay. |
keeperofdakeys
pushed a commit
to keeperofdakeys/rust
that referenced
this pull request
Dec 12, 2017
…xcrichton linux: Support getting and setting the cpu affinity for the current pthread. This implements `pthread_getaffinity_np` and `pthread_setaffinity_np` for linux.
noscripter
pushed a commit
to noscripter/rust
that referenced
this pull request
Sep 8, 2025
rust-bors Bot
pushed a commit
that referenced
this pull request
Apr 30, 2026
Add regression test for #298
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pretty-printed stuff now tends to compile (though there's this issue with @mutable not parsing, so I haven't tried compiling a fully pretty-printed rustc). It also usually looks quite okay, except that line overflows in nested 'horizontal' blocks are handled pretty poorly and tend to result in hideous right-margin-hugging messes. I'll look further into that at some point in the future.