[WIP] test enabling i128 lowering for emscripten#49487
Closed
est31 wants to merge 3 commits intorust-lang:masterfrom
Closed
[WIP] test enabling i128 lowering for emscripten#49487est31 wants to merge 3 commits intorust-lang:masterfrom
est31 wants to merge 3 commits intorust-lang:masterfrom
Conversation
401222f to
2515c5c
Compare
Member
Author
|
I see the following failures: run-pass/float-int-invalid-const-cast.rs run-pass/i128.rs run-pass/intrinsics-integer.rs run-pass/saturating-float-casts.rs So every test I enabled failed. It tested the |
Member
Author
hmmm this is something else than lowering that fails. |
Member
|
Not even being able to pass/return i128 was what blocked me last time: rust/src/test/mir-opt/lower_128bit_debug_test.rs Lines 11 to 14 in 15e8c5d |
Member
Author
|
Guess I'm closing this then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maybe this fixes the issues emscripten has with i128. Maybe not.
DO NOT MERGE