New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Const-stabilize `const_int_ops` + `const_ip` #57234

Merged
merged 10 commits into from Jan 12, 2019

Conversation

Projects
None yet
6 participants
@Centril
Copy link
Contributor

Centril commented Dec 31, 2018

r? @oli-obk

Note for relnotes: This PR includes #57105.

I've added T-lang since this affects intrinsics and the operational semantics of Rust's const fn fragment.

Stable APIs proposed for constification

  • const_int_ops:
    • count_ones
    • count_zeros
    • leading_zeros
    • trailing_zeros
    • swap_bytes
    • from_be
    • from_le
    • to_be
    • to_le
  • const_ip
    • Ipv4Addr::new

Unstable APIs constified

  • const_int_conversion:
    • reverse_bits
@Centril

This comment has been minimized.

Copy link
Contributor

Centril commented Dec 31, 2018

@rfcbot merge

@rfcbot

This comment has been minimized.

Copy link

rfcbot commented Dec 31, 2018

Team member @Centril has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot

This comment has been minimized.

Copy link

rfcbot commented Jan 8, 2019

🔔 This is now entering its final comment period, as per the review above. 🔔

@oli-obk

This comment has been minimized.

Copy link
Contributor

oli-obk commented Jan 11, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 11, 2019

📌 Commit 14be8a7 has been approved by oli-obk

Centril added a commit to Centril/rust that referenced this pull request Jan 11, 2019

Rollup merge of rust-lang#57234 - Centril:const-stabilizations-2, r=o…
…li-obk

Const-stabilize `const_int_ops` + `const_ip`

r? @oli-obk

I've added T-lang since this affects intrinsics and the operational semantics of Rust's `const fn` fragment.
This PR depends on rust-lang#57105 but the FCP intent does not.

## Stable APIs proposed for constification

+ `const_int_ops`:
    + `count_ones`
    + `count_zeros`
    + `leading_zeros`
    + `trailing_zeros`
    + `swap_bytes`
    + `from_be`
    + `from_le`
    + `to_be`
    + `to_le`
+ `const_ip`
    + `Ipv4Addr::new`

## Unstable APIs constified

+ `const_int_conversion`:
    + `reverse_bits`

Centril added a commit to Centril/rust that referenced this pull request Jan 11, 2019

Rollup merge of rust-lang#57234 - Centril:const-stabilizations-2, r=o…
…li-obk

Const-stabilize `const_int_ops` + `const_ip`

r? @oli-obk

I've added T-lang since this affects intrinsics and the operational semantics of Rust's `const fn` fragment.
This PR depends on rust-lang#57105 but the FCP intent does not.

## Stable APIs proposed for constification

+ `const_int_ops`:
    + `count_ones`
    + `count_zeros`
    + `leading_zeros`
    + `trailing_zeros`
    + `swap_bytes`
    + `from_be`
    + `from_le`
    + `to_be`
    + `to_le`
+ `const_ip`
    + `Ipv4Addr::new`

## Unstable APIs constified

+ `const_int_conversion`:
    + `reverse_bits`

bors added a commit that referenced this pull request Jan 11, 2019

Auto merge of #57513 - Centril:rollup, r=Centril
Rollup of 2 pull requests

Successful merges:

 - #57175 (Stabilize `let` bindings and destructuring in constants and const fn)
 - #57234 (Const-stabilize `const_int_ops` + `const_ip`)

Failed merges:

r? @ghost
@Centril

This comment has been minimized.

Copy link
Contributor

Centril commented Jan 11, 2019

@bors p=1

Giving prio since stabilization.

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 11, 2019

⌛️ Testing commit 14be8a7 with merge 3bdcaae...

bors added a commit that referenced this pull request Jan 11, 2019

Auto merge of #57234 - Centril:const-stabilizations-2, r=oli-obk
Const-stabilize `const_int_ops` + `const_ip`

r? @oli-obk

Note for relnotes: This PR includes #57105.

I've added T-lang since this affects intrinsics and the operational semantics of Rust's `const fn` fragment.

## Stable APIs proposed for constification

+ `const_int_ops`:
    + `count_ones`
    + `count_zeros`
    + `leading_zeros`
    + `trailing_zeros`
    + `swap_bytes`
    + `from_be`
    + `from_le`
    + `to_be`
    + `to_le`
+ `const_ip`
    + `Ipv4Addr::new`

## Unstable APIs constified

+ `const_int_conversion`:
    + `reverse_bits`
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 12, 2019

💔 Test failed - checks-travis

@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

rust-highfive commented Jan 12, 2019

The job dist-x86_64-apple of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[00:03:18]       Memory: 8 GB
[00:03:18]       Boot ROM Version: VMW71.00V.0.B64.1704110547
[00:03:18]       Apple ROM Info: [MS_VM_CERT/SHA1/27d66596a61c48dd3dc7216fd715126e33f59ae7]Welcome to the Virtual Machine
[00:03:18]       SMC Version (system): 2.8f0
[00:03:18]       Serial Number (system): VMGAlaAiPTHr
[00:03:18] 
[00:03:18] hw.ncpu: 4
[00:03:18] hw.byteorder: 1234
[00:03:18] hw.memsize: 8589934592
---

[02:50:38] travis_time:end:stage2-cargo:start=1547255699374468000,finish=1547255701016416000,duration=1641948000

[02:50:38] [TIMING] ToolBuild { compiler: Compiler { stage: 2, host: "x86_64-apple-darwin" }, target: "x86_64-apple-darwin", tool: "cargo", path: "src/tools/cargo", mode: ToolRustc, is_optional_tool: false, source_type: Submodule, extra_features: [] } -- 1.724
The job exceeded the maximum time limit for jobs, and has been terminated.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Centril

This comment has been minimized.

Copy link
Contributor

Centril commented Jan 12, 2019

@bors retry

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 12, 2019

⌛️ Testing commit 14be8a7 with merge 0c91f3d...

bors added a commit that referenced this pull request Jan 12, 2019

Auto merge of #57234 - Centril:const-stabilizations-2, r=oli-obk
Const-stabilize `const_int_ops` + `const_ip`

r? @oli-obk

## Note for relnotes: This PR includes #57105.

I've added T-lang since this affects intrinsics and the operational semantics of Rust's `const fn` fragment.

## Stable APIs proposed for constification

+ `const_int_ops`:
    + `count_ones`
    + `count_zeros`
    + `leading_zeros`
    + `trailing_zeros`
    + `swap_bytes`
    + `from_be`
    + `from_le`
    + `to_be`
    + `to_le`
+ `const_ip`
    + `Ipv4Addr::new`

## Unstable APIs constified

+ `const_int_conversion`:
    + `reverse_bits`
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 12, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: oli-obk
Pushing 0c91f3d to master...

@bors bors merged commit 14be8a7 into rust-lang:master Jan 12, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@Centril Centril deleted the Centril:const-stabilizations-2 branch Jan 12, 2019

@Centril Centril removed the T-lang label Jan 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment