New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize #![feature(if_while_or_patterns)] #57532

Merged
merged 1 commit into from Jan 12, 2019

Conversation

Projects
None yet
4 participants
@Centril
Copy link
Contributor

Centril commented Jan 11, 2019

r? @varkor

Per #56212 (comment).
Leading | is also accepted per the comment in the stabilization proposal.

@varkor

This comment has been minimized.

Copy link
Member

varkor commented Jan 11, 2019

r=me once Travis passes.

@Centril

This comment has been minimized.

Copy link
Contributor Author

Centril commented Jan 12, 2019

@bors r=varkor p=1

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 12, 2019

📌 Commit 561483e has been approved by varkor

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 12, 2019

⌛️ Testing commit 561483e with merge a868eca...

bors added a commit that referenced this pull request Jan 12, 2019

Auto merge of #57532 - Centril:stabilize-2175, r=varkor
Stabilize #![feature(if_while_or_patterns)]

r? @varkor

Per #56212 (comment).
Leading `|` is also accepted per the comment in the stabilization proposal.
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 12, 2019

💔 Test failed - checks-travis

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Jan 12, 2019

The job x86_64-gnu-full-bootstrap of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[01:13:26] [RUSTC-TIMING] rustc_errors test:false 19.645
[01:15:20] [RUSTC-TIMING] syntax test:false 113.757
[01:15:20]    Compiling syntax_ext v0.0.0 (/checkout/src/libsyntax_ext)
[01:16:20] [RUSTC-TIMING] syntax_ext test:false 60.607
No output has been received in the last 30m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Centril

This comment has been minimized.

Copy link
Contributor Author

Centril commented Jan 12, 2019

@bors retry

Seems spurious.

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 12, 2019

⌛️ Testing commit 561483e with merge aaccd3e...

bors added a commit that referenced this pull request Jan 12, 2019

Auto merge of #57532 - Centril:stabilize-2175, r=varkor
Stabilize #![feature(if_while_or_patterns)]

r? @varkor

Per #56212 (comment).
Leading `|` is also accepted per the comment in the stabilization proposal.
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 12, 2019

💔 Test failed - checks-travis

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Jan 12, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[00:05:21]    Compiling crc32fast v1.1.2
[00:05:21] [RUSTC-TIMING] graphviz test:false 0.844
[00:05:21]    Compiling scoped-tls v0.1.2
[00:05:21] [RUSTC-TIMING] scoped_tls test:false 0.231
No output has been received in the last 30m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Centril

This comment has been minimized.

Copy link
Contributor Author

Centril commented Jan 12, 2019

Still seems spurious...

@bors retry

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 12, 2019

⌛️ Testing commit 561483e with merge 1190f7c...

bors added a commit that referenced this pull request Jan 12, 2019

Auto merge of #57532 - Centril:stabilize-2175, r=varkor
Stabilize #![feature(if_while_or_patterns)]

r? @varkor

Per #56212 (comment).
Leading `|` is also accepted per the comment in the stabilization proposal.
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 12, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: varkor
Pushing 1190f7c to master...

@bors bors merged commit 561483e into rust-lang:master Jan 12, 2019

1 check passed

homu Test successful
Details

@Centril Centril deleted the Centril:stabilize-2175 branch Jan 12, 2019

@bors bors referenced this pull request Jan 12, 2019

Merged

Stabilize cfg_target_vendor #57465

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment