New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libarena => 2018 #58105

Merged
merged 1 commit into from Feb 12, 2019

Conversation

Projects
None yet
4 participants
@Centril
Copy link
Contributor

Centril commented Feb 3, 2019

Transitions libarena to Rust 2018; cc #58099

r? @oli-obk

@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

rust-highfive commented Feb 3, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:0f48edc5:start=1549204209406195442,finish=1549204281582192805,duration=72175997363
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
travis_time:start:test_debuginfo
Check compiletest suite=debuginfo mode=debuginfo-both (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:09:18] 
[01:09:18] running 119 tests
[01:09:42] .iiiii...i.....i..i...i..i.i..i.ii...i.....i..i....i..........iiii..........i...ii...i.......ii.i.i. 100/119
[01:09:46] i......iii.i.....ii
[01:09:46] 
[01:09:46]  finished in 28.688
[01:09:46] travis_fold:end:test_debuginfo

---
[01:28:50]    Compiling arena v0.0.0 (/checkout/src/libarena)
[01:28:50] error: hidden lifetime parameters in types are deprecated
[01:28:50]    --> src/libarena/lib.rs:516:25
[01:28:50]     |
[01:28:50] 516 |                 let r: &EI = self.0.alloc(EI::I(f()));
[01:28:50] 
[01:28:50] error: hidden lifetime parameters in types are deprecated
[01:28:50]    --> src/libarena/lib.rs:524:25
[01:28:50]     |
[01:28:50]     |
[01:28:50] 524 |                 let r: &EI = self.0.alloc(EI::O(f()));
[01:28:50] 
[01:28:50] error: hidden lifetime parameters in types are deprecated
[01:28:50]    --> src/libarena/lib.rs:523:67
[01:28:50]     |
[01:28:50]     |
[01:28:50] 523 |             fn alloc_outer<F: Fn() -> Outer<'a>>(&self, f: F) -> &Outer {
[01:28:50] 
[01:28:50] error: hidden lifetime parameters in types are deprecated
[01:28:50]    --> src/libarena/lib.rs:624:35
[01:28:50]     |
[01:28:50]     |
[01:28:50] 624 |             let arena: TypedArena<DropCounter> = TypedArena::default();
[01:28:50] 
[01:28:50] error: hidden lifetime parameters in types are deprecated
[01:28:50]    --> src/libarena/lib.rs:636:35
[01:28:50]     |
[01:28:50]     |
[01:28:50] 636 |         let mut arena: TypedArena<DropCounter> = TypedArena::default();
[01:28:50] 
[01:28:50] error: aborting due to 5 previous errors
[01:28:50] 
[01:28:50] error: Could not compile `arena`.
[01:28:50] error: Could not compile `arena`.
[01:28:50] 
[01:28:50] To learn more, run the command again with --verbose.
[01:28:50] 
[01:28:50] 
[01:28:50] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--features" "" "--manifest-path" "/checkout/src/rustc/Cargo.toml" "-p" "arena" "--" "--quiet"
[01:28:50] 
[01:28:50] 
[01:28:50] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:28:50] Build completed unsuccessfully in 0:31:02
[01:28:50] Build completed unsuccessfully in 0:31:02
[01:28:50] Makefile:48: recipe for target 'check' failed
[01:28:50] make: *** [check] Error 1
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:0722ab76
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Sun Feb  3 16:00:21 UTC 2019

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@oli-obk

This comment has been minimized.

Copy link
Contributor

oli-obk commented Feb 4, 2019

r=me rollup with travis passing

@Centril Centril force-pushed the Centril:libarena-trans-2018 branch from 9328414 to 7f5ef1c Feb 11, 2019

@Centril Centril force-pushed the Centril:libarena-trans-2018 branch from 7f5ef1c to f996e2b Feb 11, 2019

@Centril

This comment has been minimized.

Copy link
Contributor Author

Centril commented Feb 12, 2019

@bors r=oli-obk rollup

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 12, 2019

📌 Commit f996e2b has been approved by oli-obk

Centril added a commit to Centril/rust that referenced this pull request Feb 12, 2019

Rollup merge of rust-lang#58105 - Centril:libarena-trans-2018, r=oli-obk
libarena => 2018

Transitions `libarena` to Rust 2018; cc rust-lang#58099

r? @oli-obk

bors added a commit that referenced this pull request Feb 12, 2019

Auto merge of #58389 - Centril:rollup, r=Centril
Rollup of 11 pull requests

Successful merges:

 - #58105 (libarena => 2018)
 - #58111 (libterm => 2018)
 - #58287 (rustc-std-workspace-core => 2018)
 - #58288 (rustc-workspace-hack => 2018)
 - #58300 (librustc_typeck => 2018)
 - #58313 (Use `?` in librustc macros)
 - #58318 (libserialize => 2018)
 - #58322 (librustc_codegen_ssa => 2018)
 - #58342 (Revert removed #![feature(nll)])
 - #58367 (Remove two dead functions.)
 - #58382 (docs: remove "experimental" wording from std::os::unix)

Failed merges:

r? @ghost

@bors bors merged commit f996e2b into rust-lang:master Feb 12, 2019

@Centril Centril deleted the Centril:libarena-trans-2018 branch Feb 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment