New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use `?` in librustc macros #58313

Merged
merged 1 commit into from Feb 12, 2019

Conversation

Projects
None yet
5 participants
@matthewjasper
Copy link
Contributor

matthewjasper commented Feb 8, 2019

No description provided.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Feb 8, 2019

r? @oli-obk

(rust_highfive has picked a reviewer for you, use r? to override)

@mark-i-m

This comment has been minimized.

Copy link
Contributor

mark-i-m commented Feb 9, 2019

Thanks! I had been meaning to do this :)

Show resolved Hide resolved src/librustc/macros.rs Outdated

@matthewjasper matthewjasper force-pushed the matthewjasper:use-question-in-macros branch from 02154ab to 0a16b87 Feb 9, 2019

@oli-obk

This comment has been minimized.

Copy link
Contributor

oli-obk commented Feb 10, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 10, 2019

📌 Commit 0a16b87 has been approved by oli-obk

pietroalbini added a commit to pietroalbini/rust that referenced this pull request Feb 10, 2019

Rollup merge of rust-lang#58313 - matthewjasper:use-question-in-macro…
…s, r=oli-obk

Use `?` in librustc macros

bors added a commit that referenced this pull request Feb 10, 2019

Auto merge of #58348 - pietroalbini:rollup, r=pietroalbini
Rollup of 19 pull requests

Successful merges:

 - #57259 (Update reference of rlibc crate to compiler-builtins crate)
 - #57740 (Use `to_ne_bytes` for converting IPv4Addr to octets)
 - #57926 (Tiny expansion to docs for `core::convert`.)
 - #58129 (MaybeUninit: some docs, rename into_inner -> into_initialized, return &mut from set)
 - #58151 (Partially HirId-ify rustc)
 - #58152 (Partially HirIdify mir)
 - #58153 (Partially Hiridify typeck)
 - #58157 (Add Cargo.lock automatically adding message)
 - #58203 (rustdoc: display sugared return types for async functions)
 - #58262 (Add #[must_use] message to Fn* traits)
 - #58295 (std::sys::unix::stdio: explain why we do into_raw)
 - #58297 (Cleanup JS a bit)
 - #58300 (librustc_typeck => 2018)
 - #58313 (Use `?` in librustc macros)
 - #58322 (librustc_codegen_ssa => 2018)
 - #58324 (miri: give non-generic functions a stable address)
 - #58332 (operand-to-place copies should never be overlapping)
 - #58345 (When there are multiple filenames, print what got interpreted as filenames)
 - #58346 (rpath computation: explain why we pop())

Failed merges:

r? @ghost

Centril added a commit to Centril/rust that referenced this pull request Feb 12, 2019

Rollup merge of rust-lang#58313 - matthewjasper:use-question-in-macro…
…s, r=oli-obk

Use `?` in librustc macros

bors added a commit that referenced this pull request Feb 12, 2019

Auto merge of #58389 - Centril:rollup, r=Centril
Rollup of 11 pull requests

Successful merges:

 - #58105 (libarena => 2018)
 - #58111 (libterm => 2018)
 - #58287 (rustc-std-workspace-core => 2018)
 - #58288 (rustc-workspace-hack => 2018)
 - #58300 (librustc_typeck => 2018)
 - #58313 (Use `?` in librustc macros)
 - #58318 (libserialize => 2018)
 - #58322 (librustc_codegen_ssa => 2018)
 - #58342 (Revert removed #![feature(nll)])
 - #58367 (Remove two dead functions.)
 - #58382 (docs: remove "experimental" wording from std::os::unix)

Failed merges:

r? @ghost

@bors bors merged commit 0a16b87 into rust-lang:master Feb 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment