Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the #[must_use] lint to boxed types #62228

Merged
merged 4 commits into from Jul 1, 2019

Conversation

Projects
None yet
5 participants
@varkor
Copy link
Member

commented Jun 29, 2019

Fixes #55506 (comment) (cc @Nemo157).

This should have been included as part of #55663, but was overlooked.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Jun 29, 2019

r? @oli-obk

(rust_highfive has picked a reviewer for you, use r? to override)

@Centril

This comment has been minimized.

Copy link
Member

commented Jun 29, 2019

r? @Centril

r=me with some more tests for interactions with combinations, e.g tuples and whatnot. Testing Box<Box<dyn MustUse>> would also be good.

@rust-highfive rust-highfive assigned Centril and unassigned oli-obk Jun 29, 2019

@varkor

This comment has been minimized.

Copy link
Member Author

commented Jun 29, 2019

@bors r=Centril

@bors

This comment has been minimized.

Copy link
Contributor

commented Jun 29, 2019

📌 Commit 238bf81 has been approved by Centril

Centril added a commit to Centril/rust that referenced this pull request Jun 29, 2019

Rollup merge of rust-lang#62228 - varkor:must_use-trait-in-box, r=Cen…
…tril

Extend the #[must_use] lint to boxed types

Fixes rust-lang#55506 (comment) (cc @Nemo157).

This should have been included as part of rust-lang#55663, but was overlooked.
@Centril

This comment has been minimized.

Copy link
Member

commented Jun 29, 2019

@bors r- due to failure.

@Centril

This comment has been minimized.

Copy link
Member

commented Jun 29, 2019

r=me rollup again when CI is happy.

@varkor

This comment has been minimized.

Copy link
Member Author

commented Jun 29, 2019

@bors r=Centril rollup

@bors

This comment has been minimized.

Copy link
Contributor

commented Jun 29, 2019

📌 Commit 1424a6b has been approved by Centril

Centril added a commit to Centril/rust that referenced this pull request Jun 29, 2019

Rollup merge of rust-lang#62235 - varkor:must_use-adt-components, r=C…
…entril

Extend the `#[must_use]` lint to arrays

Based on top of rust-lang#62228.

r? @Centril

varkor added a commit to varkor/miri that referenced this pull request Jun 30, 2019

Fix `unused_must_use` inside `Box`
After rust-lang/rust#62228, this will be linted against (and causes the test to fail).

bors added a commit to rust-lang/miri that referenced this pull request Jun 30, 2019

Auto merge of #806 - varkor:patch-1, r=RalfJung
Fix `unused_must_use` inside `Box`

After rust-lang/rust#62228, this will be linted against (and causes the test to fail). (This blocks rust-lang/rust#62228.)

@varkor varkor force-pushed the varkor:must_use-trait-in-box branch from 1424a6b to 400fd60 Jun 30, 2019

@varkor

This comment has been minimized.

Copy link
Member Author

commented Jun 30, 2019

@bors r=Centril rollup

@bors

This comment has been minimized.

Copy link
Contributor

commented Jun 30, 2019

📌 Commit 400fd60 has been approved by Centril

Centril added a commit to Centril/rust that referenced this pull request Jun 30, 2019

Rollup merge of rust-lang#62228 - varkor:must_use-trait-in-box, r=Cen…
…tril

Extend the #[must_use] lint to boxed types

Fixes rust-lang#55506 (comment) (cc @Nemo157).

This should have been included as part of rust-lang#55663, but was overlooked.

Centril added a commit to Centril/rust that referenced this pull request Jun 30, 2019

Rollup merge of rust-lang#62235 - varkor:must_use-adt-components, r=C…
…entril

Extend the `#[must_use]` lint to arrays

Based on top of rust-lang#62228.

r? @Centril

bors added a commit that referenced this pull request Jul 1, 2019

Auto merge of #62253 - Centril:rollup-115uuuq, r=Centril
Rollup of 8 pull requests

Successful merges:

 - #62062 (Use a more efficient iteration order for forward dataflow)
 - #62063 (Use a more efficient iteration order for backward dataflow)
 - #62224 (rustdoc: remove unused derives and variants)
 - #62228 (Extend the #[must_use] lint to boxed types)
 - #62235 (Extend the `#[must_use]` lint to arrays)
 - #62239 (Fix a typo)
 - #62241 (Always parse 'async unsafe fn' + properly ban in 2015)
 - #62248 (before_exec actually will only get deprecated with 1.37)

Failed merges:

r? @ghost

@bors bors merged commit 400fd60 into rust-lang:master Jul 1, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
pr Build #20190630.20 succeeded
Details

@Centril Centril added this to the 1.37 milestone Jul 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.