Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused parameters in __thread_local_inner #66146

Merged
merged 1 commit into from
Nov 7, 2019

Conversation

3442853561
Copy link
Contributor

@3442853561 3442853561 commented Nov 6, 2019

Fixes #65993.

Removed parameters not used in the macro
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 6, 2019
@3442853561 3442853561 changed the title Removed parameters not used in the macro fixed issue#65993 Nov 6, 2019
@Centril Centril changed the title fixed issue#65993 Remove unused parameters in __thread_local_inner Nov 6, 2019
@Centril Centril changed the title Remove unused parameters in __thread_local_inner Remove unused parameters in __thread_local_inner Nov 6, 2019
@Mark-Simulacrum
Copy link
Member

cc @alexcrichton

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 6, 2019

📌 Commit 936349c has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 6, 2019
@euclio
Copy link
Contributor

euclio commented Nov 6, 2019

Why remove the parameter instead of passing it onto the item? IIRC the meta argument was added so that doc comments could be added.

pietroalbini added a commit to pietroalbini/rust that referenced this pull request Nov 6, 2019
Remove unused parameters in `__thread_local_inner`

Fixes rust-lang#65993.
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Nov 6, 2019
Remove unused parameters in `__thread_local_inner`

Fixes rust-lang#65993.
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Nov 7, 2019
Remove unused parameters in `__thread_local_inner`

Fixes rust-lang#65993.
bors added a commit that referenced this pull request Nov 7, 2019
Rollup of 12 pull requests

Successful merges:

 - #65794 (gate rustc_on_unimplemented under rustc_attrs)
 - #65945 (Optimize long-linker-command-line test)
 - #66044 (Improve uninit/zeroed lint)
 - #66076 (HIR docs: mention how to resolve method paths)
 - #66084 (Do not require extra LLVM backends for `x.py test` to pass)
 - #66111 (improve from_raw_parts docs)
 - #66114 (Improve std::thread::Result documentation)
 - #66117 (Fixed PhantomData markers in Arc and Rc)
 - #66146 (Remove unused parameters in `__thread_local_inner`)
 - #66147 (Miri: Refactor to_scalar_ptr out of existence)
 - #66162 (Fix broken link in README)
 - #66171 (Update link on CONTRIBUTING.md)

Failed merges:

r? @ghost
@bors bors merged commit 936349c into rust-lang:master Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
5 participants