Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 11 pull requests #66169

Closed
wants to merge 35 commits into from
Closed

Conversation

JohnTitor
Copy link
Member

Successful merges:

Failed merges:

r? @ghost

tmiasko and others added 30 commits November 1, 2019 09:28
Replace O(n^3) text matching with inexpensive hash set lookups.

On my machine this reduces the total runtime of complete
run-make-fulldeps suite from roughly 75 seconds to 45 seconds.
Co-Authored-By: Mazdak Farrokhzad <twingoow@gmail.com>
Removed parameters not used in the macro
Co-Authored-By: Oliver Scherer <github35764891676564198441@oli-obk.de>
gate rustc_on_unimplemented under rustc_attrs

Move `rustc_on_implemented` from the `on_implemented` gate to `rustc_attrs` as it is internal.

Closes rust-lang#29628

r? @varkor
…=alexcrichton

Optimize long-linker-command-line test

Replace O(n^3) text matching with inexpensive hash set lookups.

On my machine this reduces the total runtime of complete
run-make-fulldeps suite from roughly 75 seconds to 45 seconds.
Improve uninit/zeroed lint

* Also warn when creating a raw pointer with a NULL vtable.
* Also identify `MaybeUninit::uninit().assume_init()` and `MaybeUninit::zeroed().assume_init()` as dangerous.
HIR docs: mention how to resolve method paths
Do not require extra LLVM backends for `x.py test` to pass

For long time our testing passed with a partially built LLVM
```
[llvm]
targets = "X86;ARM"
```
, a [recent PR](rust-lang#65809) changed that.
improve from_raw_parts docs

Triggered by rust-lang/rfcs#2806. Hopefully this helps clarify that joining slices across allocations is not possible in Rust currently.

r? @Centril
…RalfJung

Fixed PhantomData markers in Arc and Rc

Include owned internal structs in `PhantomData` markers in `Arc` (`PhantomData<T>` => `PhantomData<ArcInner<T>>`) and `Rc` (`PhantomData<T>` => `PhantomData<RcBox<T>>`).
Remove unused parameters in `__thread_local_inner`

Fixes rust-lang#65993.
Miri: Refactor to_scalar_ptr out of existence

`to_scalar_ptr` is somewhat subtle as it just throws away the 2nd component of a `ScalarPair` if there is one -- without any check if this is truly a pointer or so. And indeed we used it wrong on two occasions!

So I fixed those two, and then refactored things such that everyone calls `ref_to_mplace` instead (which they did anyway, I just moved up the calls), which is the only place that should interpret a `ScalarPair` as a wide ptr -- and it checks the type first. Thus we can remove `to_scalar_ptr` and `to_meta`.

r? @oli-obk
Fix broken link in README

The link to the rustc guide on building and running the compiler is broken. It was broken in [rustc-guide#491](rust-lang/rustc-dev-guide#491).
Ignore these tests ,since the called commands doesn't exist in VxWorks
@JohnTitor
Copy link
Member Author

@bors r+ p=11 rollup=never

@bors
Copy link
Contributor

bors commented Nov 6, 2019

📌 Commit 0ec60e6 has been approved by JohnTitor

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Nov 6, 2019
@JohnTitor JohnTitor added the rollup A PR which is a rollup label Nov 6, 2019
@bors
Copy link
Contributor

bors commented Nov 6, 2019

⌛ Testing commit 0ec60e6 with merge f07924e8194874a09371c967a63e969e79eff113...

@rust-highfive
Copy link
Collaborator

The job arm-android of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-11-06T23:58:17.2348202Z test time::tests::since_epoch ... ok
2019-11-06T23:58:17.2348269Z 
2019-11-06T23:58:17.2348616Z failures:
2019-11-06T23:58:17.2348665Z 
2019-11-06T23:58:17.2349458Z ---- process::tests::test_process_output_error stdout ----
2019-11-06T23:58:17.2349835Z thread '<unnamed>' panicked at 'assertion failed: status.code() == Some(1)', src/libstd/process.rs:1820:9
2019-11-06T23:58:17.2349977Z 
2019-11-06T23:58:17.2350059Z failures:
2019-11-06T23:58:17.2350129Z     process::tests::test_process_output_error
2019-11-06T23:58:17.2350197Z 
2019-11-06T23:58:17.2350197Z 
2019-11-06T23:58:17.2350278Z test result: FAILED. 748 passed; 1 failed; 13 ignored; 0 measured; 0 filtered out
2019-11-06T23:58:17.2350340Z 
2019-11-06T23:58:17.2350659Z error: test failed, to rerun pass '-p std --lib'
2019-11-06T23:58:17.2363093Z 
2019-11-06T23:58:17.2363939Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "-Zconfig-profile" "--target" "arm-linux-androideabi" "-Zbinary-dep-depinfo" "-j" "2" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace compiler-builtins-c" "--manifest-path" "/checkout/src/libtest/Cargo.toml" "-p" "std" "--"
2019-11-06T23:58:17.2364169Z expected success, got: exit code: 101
2019-11-06T23:58:17.2364221Z 
---
2019-11-06T23:58:17.2448816Z   local time: Wed Nov  6 23:58:17 UTC 2019
2019-11-06T23:58:17.5251493Z   network time: Wed, 06 Nov 2019 23:58:17 GMT
2019-11-06T23:58:17.5257566Z == end clock drift check ==
2019-11-06T23:58:18.3765471Z 
2019-11-06T23:58:18.3876135Z ##[error]Bash exited with code '1'.
2019-11-06T23:58:18.3917811Z ##[section]Starting: Checkout
2019-11-06T23:58:18.3920142Z ==============================================================================
2019-11-06T23:58:18.3920258Z Task         : Get sources
2019-11-06T23:58:18.3920345Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors
Copy link
Contributor

bors commented Nov 7, 2019

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 7, 2019
@JohnTitor JohnTitor closed this Nov 7, 2019
@JohnTitor JohnTitor deleted the rollup-4w7vuda branch November 7, 2019 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants