Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Layout::new const #66254

Open
wants to merge 1 commit into
base: master
from
Open

Make Layout::new const #66254

wants to merge 1 commit into from

Conversation

@CAD97
Copy link
Contributor

CAD97 commented Nov 9, 2019

This seems like a reasonable change to make. If we don't provide Layout::new::<T> as const, then users can just instead do the more error prone Layout::from_size_align_unchecked(mem::size_of::<T>(), mem::align_of::<T>()) for the same effect and an extra unsafe { } incantation.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Nov 9, 2019

r? @KodrAus

(rust_highfive has picked a reviewer for you, use r? to override)

@CAD97

This comment has been minimized.

Copy link
Contributor Author

CAD97 commented Nov 25, 2019

cc @rust-lang/libs for [needs-fcp]

Copy link
Contributor

KodrAus left a comment

This looks good to me!

@rfcbot fcp merge

@sfackler

This comment has been minimized.

Copy link
Member

sfackler commented Nov 30, 2019

@rfcbot fcp merge

@rfcbot

This comment has been minimized.

Copy link

rfcbot commented Nov 30, 2019

Team member @sfackler has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot

This comment has been minimized.

Copy link

rfcbot commented Dec 5, 2019

🔔 This is now entering its final comment period, as per the review above. 🔔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.