Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an early-exit to `QueryNormalizer::fold_ty` #68606

Merged
merged 1 commit into from Jan 28, 2020

Conversation

@jonas-schievink
Copy link
Member

jonas-schievink commented Jan 28, 2020

Pulled out from #68524, this results in a ~60-70% reduction in compile time for the await-call-tree benchmarks. This should unblock #67982 as well.

r? @Zoxc

@jonas-schievink

This comment was marked as outdated.

Copy link
Member Author

jonas-schievink commented Jan 28, 2020

@bors rollup

@Centril

This comment has been minimized.

Copy link
Member

Centril commented Jan 28, 2020

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Copy link

rust-timer commented Jan 28, 2020

Awaiting bors try build completion

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 28, 2020

⌛️ Trying commit 474d0e3 with merge 0c5d24e...

bors added a commit that referenced this pull request Jan 28, 2020
Add an early-exit to `QueryNormalizer::fold_ty`

Pulled out from #68524, this results in a ~60-70% reduction in compile time for the await-call-tree benchmarks. This should unblock #67982 as well.

r? @Zoxc
@jonas-schievink

This comment has been minimized.

Copy link
Member Author

jonas-schievink commented Jan 28, 2020

@bors rollup=never

@Centril

This comment has been minimized.

Copy link
Member

Centril commented Jan 28, 2020

@bors rollup=never since this is a perf win, and we want to avoid masking regressions from other PRs in the rollup.

@Centril

This comment has been minimized.

Copy link
Member

Centril commented Jan 28, 2020

Seems like we already did the perf testing @bors try-

@Zoxc

This comment has been minimized.

Copy link
Contributor

Zoxc commented Jan 28, 2020

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 28, 2020

📌 Commit 474d0e3 has been approved by Zoxc

@Zoxc

This comment has been minimized.

Copy link
Contributor

Zoxc commented Jan 28, 2020

@bors p=1

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 28, 2020

⌛️ Testing commit 474d0e3 with merge 3761dcd...

bors added a commit that referenced this pull request Jan 28, 2020
Add an early-exit to `QueryNormalizer::fold_ty`

Pulled out from #68524, this results in a ~60-70% reduction in compile time for the await-call-tree benchmarks. This should unblock #67982 as well.

r? @Zoxc
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 28, 2020

☀️ Test successful - checks-azure
Approved by: Zoxc
Pushing 3761dcd to master...

@bors bors added the merged-by-bors label Jan 28, 2020
@bors bors merged commit 474d0e3 into rust-lang:master Jan 28, 2020
5 checks passed
5 checks passed
homu Test successful
Details
pr Build #20200128.32 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-7) Linux x86_64-gnu-llvm-7 succeeded
Details
pr (Linux x86_64-gnu-tools) Linux x86_64-gnu-tools succeeded
Details
@jonas-schievink jonas-schievink deleted the jonas-schievink:normalize-fastpath branch Jan 28, 2020
bors added a commit that referenced this pull request Feb 3, 2020
Re-land "add IntoFuture trait and support for await"

Testing the code from #65244 to see if the performance regressions are still there. #68606 and #68672 made perf optimizations that might interact with this change.

If this lands, fixes #67982.

cc @seanmonstar @jonas-schievink
r? @cramertj
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.