Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #75116

Closed
wants to merge 14 commits into from

Conversation

Manishearth
Copy link
Member

Successful merges:

Failed merges:

r? @ghost

carbotaniuman and others added 14 commits July 29, 2020 10:38
The purpose of the auto-fallible job is to run builders that are likely
to fail on CI without gating on them. Having fast-fail enabled there
kinda defeats the purpose, as if one of them fails we can't monitor the
outcome of the other ones.

This was prompted by the aarch64-gnu builder consistently failing due to
a broken test, preventing us from seeing if the macOS spurious failure
is fixed.
riscv64 has an LLVM bug that makes rust-analyzer not build.
add `unsigned_abs` to signed integers

Mentioned on rust-lang/rfcs#2914

This PR simply adds an `unsigned_abs` to signed integers function which returns the correct absolute value as a unsigned integer.
…-obk

Lint path statements to suggest using drop when the type needs drop

Fixes rust-lang#48852. With this change the current lint description doesn't really fit entirely anymore I think.
…ark-Simulacrum

Clarify reuse of a BTreeMap insert support function and treats split support likewise

r? @Mark-Simulacrum
…r=lcnr

Do not trigger `unused_braces` for `while let`

Follow-up for rust-lang#75031
r? @lcnr
…Mark-Simulacrum

ci: disable fast-fail on auto-fallible

The purpose of the auto-fallible job is to run builders that are likely to fail on CI without gating on them. Having fast-fail enabled there kinda defeats the purpose, as if one of them fails we can't monitor the outcome of the other ones.

This was prompted by the aarch64-gnu builder consistently failing due to a broken test, preventing us from seeing if the macOS spurious failure is fixed.

r? @Mark-Simulacrum
…r=matklad

Disable building rust-analyzer on riscv64

riscv64 has an LLVM bug that makes rust-analyzer not build. Should permit future rust-analyzer ups (e.g., rust-lang#74813) to land.
@Manishearth
Copy link
Member Author

@rustbot modify labels: +rollup
@bors r+ rollup=never p=5

@bors
Copy link
Contributor

bors commented Aug 3, 2020

📌 Commit 1be0d55 has been approved by Manishearth

@rustbot rustbot added the rollup A PR which is a rollup label Aug 3, 2020
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 3, 2020
@bors
Copy link
Contributor

bors commented Aug 3, 2020

⌛ Testing commit 1be0d55 with merge 41dd10b6d2253e62a8abba4ecf160ceb5fe3d9f8...

@alex
Copy link
Member

alex commented Aug 3, 2020

@Manishearth it looks like GHA never actually triggered here, so I don't think this will ever succeed

@Manishearth
Copy link
Member Author

@bors retry yield

@bors
Copy link
Contributor

bors commented Aug 3, 2020

⌛ Testing commit 1be0d55 with merge 8805f7f58379998337cdba5c4224df095e525d40...

@alex
Copy link
Member

alex commented Aug 3, 2020

It didn't trigger again -- I only see the AP jobs on that commit not the GHA ones.

@Mark-Simulacrum
Copy link
Member

@bors r-

The workflow is not valid. .github/workflows/ci.yml (Line: 578, Col: 7): Unexpected value 'fast-fail'

From https://github.com/rust-lang-ci/rust/actions/runs/193864895

Closing.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.