Rollup of 12 pull requests #76019
Merged
Rollup of 12 pull requests #76019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also cleaned up some things and added a few more links.
Co-authored-by: Joshua Nelson <joshua@yottadb.com>
Co-authored-by: Joshua Nelson <joshua@yottadb.com>
This modules contains the implementation of doctests, and not the tests of rustdoc itself. This name is confusing, so let's rename it to doctest for clarity.
C-like enums are still allowed to impl drop, you just can't cast them to numbers
All other Platform files included in `llvm-project/compiler-rt` were present, except Fuchsia. Now that there is a functional end-to-end version of `-Zinstrument-coverage`, I need to start building and testing coverage-enabled Rust programs on Fuchsia, and this file is required.
The ability to "bless" output for some of these tests is critical to making it practical to adapt tests to unrelated changes. This is needed for new coverage tests, as shown in PR rust-lang#75828 (or its derivative).
Co-authored-by: Joshua Nelson <joshua@yottadb.com>
…=GuillaumeGomez Improve rendering of crate features via doc(cfg) The current rendering of crate features with `doc(cfg(feature = ".."))` is verbose and unwieldy for users, `doc(cfg(target_feature = ".."))` is special-cased to make it render nicely, and a similar rendering can be applied to `doc(cfg(feature))` to make it easier for users to read. I also added special casing of `all`/`any` cfgs consisting of just `feature`/`target-feature` to remove the repetitive "target/crate feature" prefix. The downside of this current rendering is that there is no distinction between `feature` and `target_feature` in the shorthand display. IMO this is ok, or if anything `target_feature` should have a more verbose shorthand, because `doc(cfg(feature = ".."))` usage is going to vastly outstrip `doc(cfg(target_feature = ".."))` usage in non-stdlib crates when it eventually stabilizes (or even before that given the number of crates using `cfg_attr(docsrs)` like constructs). ## Previously <img width="259" alt="Screenshot 2020-08-09 at 13 32 42" src="https://user-images.githubusercontent.com/81079/89731110-d090c000-da44-11ea-96fa-56adc6339123.png"> <img width="438" alt="image" src="https://user-images.githubusercontent.com/81079/89731116-d7b7ce00-da44-11ea-87c6-022d192d6eca.png"> <img width="765" alt="image" src="https://user-images.githubusercontent.com/81079/89731152-24030e00-da45-11ea-9552-1c270bff2729.png"> <img width="671" alt="image" src="https://user-images.githubusercontent.com/81079/89731158-28c7c200-da45-11ea-8acb-97d8a4ce00eb.png"> ## Now <img width="216" alt="image" src="https://user-images.githubusercontent.com/81079/89731123-e1d9cc80-da44-11ea-82a8-5900bd9448a5.png"> <img width="433" alt="image" src="https://user-images.githubusercontent.com/81079/89731127-e8684400-da44-11ea-9d18-572fd810f19f.png"> <img width="606" alt="image" src="https://user-images.githubusercontent.com/81079/89731162-2feed000-da45-11ea-98d2-8a88c364d903.png"> <img width="669" alt="image" src="https://user-images.githubusercontent.com/81079/89731991-ccb46c00-da4b-11ea-9416-cd20a3193826.png"> cc rust-lang#43781
…cros, r=jyn514 Use intra-doc links in `core::macros` Part of rust-lang#75080. Also cleaned up some things. @rustbot modify labels: A-intra-doc-links T-doc T-rustdoc
…an-DPC Clean up E0761 explanation r? @Dylan-DPC
…alfJung Fix potential UB in align_offset doc examples Currently it takes a pointer only to the first element in the array, this changes the code to take a pointer to the whole array. miri can't catch this right now because it later calls `x.len()` which re-tags the pointer for the whole array. rust-lang/miri#1526 (comment)
Error use explicit intra-doc link and fix text Follow up of rust-lang#75629 r? @jyn514
…and-dec2flt, r=jyn514 Use intra-doc links in `core::future::future` and `core::num::dec2flt` Part of rust-lang#75080. @rustbot modify labels: A-intra-doc-links T-doc
Fix typo in `std::hint::black_box` docs
Fix ICE due to carriage return w/ multibyte char Based off of this [commit](kfitch@972560b) Fixes rust-lang#70381 CC: @Dylan-DPC
…umeGomez Rename rustdoc/test -> rustdoc/doctest This modules contains the implementation of doctests, and not the tests of rustdoc itself. This name is confusing, so let's rename it to doctest for clarity.
fix wording in release notes C-like enums are still allowed to impl drop, you just can't cast them to numbers
…1, r=wesleywiser Add InstrProfilingPlatformFuchsia.c to profiler_builtins All other Platform files included in `llvm-project/compiler-rt` were present, except Fuchsia. Now that there is a functional end-to-end version of `-Zinstrument-coverage`, I need to start building and testing coverage-enabled Rust programs on Fuchsia, and this file is required. r? @tmandry FYI, @wesleywiser
…2, r=wesleywiser Adds --bless support to test/run-make-fulldeps The ability to "bless" output for some of these tests is critical to making it practical to adapt tests to unrelated changes. This is needed for new coverage tests, as shown in PR rust-lang#76004 . r? @tmandry FYI: @wesleywiser
|
📌 Commit 0106ad4 has been approved by |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions, checks-azure |
This was referenced Aug 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
core::macros#75927 (Use intra-doc links incore::macros)core::future::futureandcore::num::dec2flt#75955 (Use intra-doc links incore::future::futureandcore::num::dec2flt)std::hint::black_boxdocs #75967 (Fix typo instd::hint::black_boxdocs)Failed merges:
r? @ghost