Add comments around code where ordering is important due for panic-safety #86521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
RalfJung
reviewed
Jun 22, 2021
…fety Iterators contain arbitrary code which may panic. Unsafe code has to be careful to do its state updates at the right point between calls that may panic.
the8472
force-pushed
the
add-footgun-comments
branch
from
4d38bbb
to
e0d7015
Compare
|
Thanks a lot. :) I can't actually judge this is the context of the surrounding code, but it all seems reasonable and I trust you know that code way better than I do. :) |
|
📌 Commit e0d7015 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 22, 2021
Rollup of 6 pull requests Successful merges: - rust-lang#86223 (Specify the kind of the item for E0121) - rust-lang#86521 (Add comments around code where ordering is important due for panic-safety) - rust-lang#86523 (Improvements to intra-doc link macro disambiguators) - rust-lang#86542 (Line numbers aligned with content) - rust-lang#86549 (Add destructuring example of E0508) - rust-lang#86557 (Update books) Failed merges: - rust-lang#86548 (Fix crate filter search reset) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Iterators contain arbitrary code which may panic. Unsafe code has to be
careful to do its state updates at the right point between calls that may panic.
As requested in #86452 (comment)
r? @RalfJung