Improvements to intra-doc link macro disambiguators #86523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occurred in intra-doc-links. cc @jyn514 |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
LeSeulArtichaut
force-pushed
the
macros-disambiguators
branch
2 times, most recently
from
f6179cd
to
718bc9e
Compare
This comment has been minimized.
This comment has been minimized.
LeSeulArtichaut
force-pushed
the
macros-disambiguators
branch
from
718bc9e
to
5d6abc9
Compare
jyn514
added
A-intra-doc-links
jyn514
reviewed
Jun 21, 2021
jyn514
added
S-waiting-on-author
LeSeulArtichaut
force-pushed
the
macros-disambiguators
branch
from
5d6abc9
to
26b44c0
Compare
LeSeulArtichaut
added
S-waiting-on-review
|
@jyn514 Addressed your comments |
LeSeulArtichaut
force-pushed
the
macros-disambiguators
branch
from
26b44c0
to
f387e8c
Compare
jyn514
approved these changes
Jun 22, 2021
|
@bors r+ Thanks! |
|
📌 Commit f387e8c has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 22, 2021
Rollup of 6 pull requests Successful merges: - rust-lang#86223 (Specify the kind of the item for E0121) - rust-lang#86521 (Add comments around code where ordering is important due for panic-safety) - rust-lang#86523 (Improvements to intra-doc link macro disambiguators) - rust-lang#86542 (Line numbers aligned with content) - rust-lang#86549 (Add destructuring example of E0508) - rust-lang#86557 (Update books) Failed merges: - rust-lang#86548 (Fix crate filter search reset) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few small improvements around macro disambiguators:
[macro!()]would be displayed without the parantheses (fixes Intra-doc linkfoo!()is rendered without the parentheses #86309)!{}and![]as macro disambiguators (fixes Intra-doc links don't accept all macro delimiters #86310)r? @jyn514 cc @Manishearth @camelid