Line numbers aligned with content #86542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
added
the
T-rustdoc
rust-highfive
added
the
S-waiting-on-review
jyn514
reviewed
Jun 22, 2021
Comment on lines
+14
to
+15
| // This is to ensure that the content is correctly align with the line numbers. | ||
| compare-elements-position: ("//*[@id='1']", ".rust > span", ("y")) |
There was a problem hiding this comment.
This doesn't hurt, but I also don't think it helps very much? Usually the isuses come from less common browsers because the line numbers use a metric ton of CSS to allow being out-of-line with the code itself.
There was a problem hiding this comment.
Not at all. The issue appeared at least three times on all browsers. There were the line numbers and then completely below the source code. It was caused by changes on the CSS as you may have guessed. ;)
|
r=me if you're ok with closing #86541 and merging it as part of this one |
|
Sounds good to me. Thanks for the quick review! @bors: r=jyn514 |
|
📌 Commit 5c9e10e has been approved by |
bors
added
S-waiting-on-bors
This was referenced Jun 22, 2021
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 22, 2021
Rollup of 6 pull requests Successful merges: - rust-lang#86223 (Specify the kind of the item for E0121) - rust-lang#86521 (Add comments around code where ordering is important due for panic-safety) - rust-lang#86523 (Improvements to intra-doc link macro disambiguators) - rust-lang#86542 (Line numbers aligned with content) - rust-lang#86549 (Add destructuring example of E0508) - rust-lang#86557 (Update books) Failed merges: - rust-lang#86548 (Fix crate filter search reset) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 23, 2021
…h-reset, r=jsha Fix crate filter search reset I found a fun bug when using rustdoc recently: I made a search, cut the search input content, changed the crate filter, pasted back the input content. To my surprise, the crate filter wasn't applied. It's because that our search input was empty when receiving the `<select>` "onchange" event. To fix this issue, I reset the `currentResults` variable to `null`. It's using the first commit from rust-lang#86542 so it needs to wait for it before getting merged. r? `@jsha`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had the issue a few times in the past where the source code pages' content wasn't aligned with the line numbers but completely below. This test will prevent this change to go unnoticed.
The first commit comes from #86541 so it needs it to be merged first.
r? @jsha