Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #86559

Merged
merged 17 commits into from
Jun 23, 2021
Merged

Rollup of 6 pull requests #86559

merged 17 commits into from
Jun 23, 2021

Conversation

Dylan-DPC-zz
Copy link

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

fee1-dead and others added 17 commits June 22, 2021 00:40
This adds an example that destructures the array to move the value, instead of taking a reference or cloning.
…fety

Iterators contain arbitrary code which may panic. Unsafe code has to be
careful to do its state updates at the right point between calls
that may panic.
…fJung

Add comments around code where ordering is important due for panic-safety

Iterators contain arbitrary code which may panic. Unsafe code has to be
careful to do its state updates at the right point between calls that may panic.

As requested in rust-lang#86452 (comment)

r? `@RalfJung`
…rs, r=jyn514

Improvements to intra-doc link macro disambiguators

A few small improvements around macro disambiguators:
- display the link text as it was entered: previously `[macro!()]` would be displayed without the parantheses (fixes rust-lang#86309)
- support `!{}` and `![]` as macro disambiguators (fixes rust-lang#86310)

r? `@jyn514` cc `@Manishearth` `@camelid`
…-with-content, r=jyn514

Line numbers aligned with content

We had the issue a few times in the past where the source code pages' content wasn't aligned with the line numbers but completely below. This test will prevent this change to go unnoticed.

The first commit comes from rust-lang#86541 so it needs it to be merged first.

r? `@jsha`
Add destructuring example of E0508

This adds an example that destructures the array to move the value, instead of taking a reference or cloning.
Update books

## nomicon

10 commits in 55de6fa3c1f331774da19472c9ee57d2ae9eb039..b9ca313e687c991223e23e5520529815dc281205
2021-05-12 00:31:01 +0900 to 2021-06-22 12:02:20 -0400
- The #[repr(C)] attribute on the callback example is not necessary, since the type is not used in C.
- Reorganize some chapters (rust-lang/nomicon#282)
- Mention "extern types" on the opaque structs section (rust-lang/nomicon#273)
- Clarify the conditions on the aliasing section (rust-lang/nomicon#272)
- Upgrade to edition 2018 (rust-lang/nomicon#280)
- Update some wording making reference to issues/RFCs (rust-lang/nomicon#271)
- Some improvements on the "subtyping" chapter (rust-lang/nomicon#278)
- Clarify casting between the same size fixed ints (rust-lang/nomicon#277)
- Add a link to show why unused lifetimes on structs are forbidden (rust-lang/nomicon#276)
- Fix small typo in the Drop Check chapter (rust-lang/nomicon#275)

## reference

8 commits in 8f598e2af6c25b4a7ee88ef6a8196d9b8ea50ca8..d9699fa8f3186440fdaadd703d63d8d42322c176
2021-06-01 19:00:46 +0100 to 2021-06-21 12:23:10 -0700
- Make explicit reference to scrutinee expression in grammar snippet (rust-lang/reference#1044)
- Document sub-namespaces. (rust-lang/reference#1043)
- Default all examples to 2018 edition. (rust-lang/reference#1041)
- Minor update to macros. (rust-lang/reference#1048)
-  (rust-lang/reference#1049)
- Add a note why the same size int casting is a no-op (rust-lang/reference#1046)
- Add notes on `#[target_feature]` for wasm (rust-lang/reference#1047)
- Make statement about variable visibility more precise (rust-lang/reference#1045)

## rustc-dev-guide

8 commits in c8da5bfd1c7c71d90ef1646f5e0a9f6609d5c78a..fe34beddb41dea5cb891032512a8d5b842b99696
2021-06-04 09:08:56 +0200 to 2021-06-21 21:50:12 +0200
- Update "Inference variables" section (rust-lang/rustc-dev-guide#1145)
- Document how to run unit tests (rust-lang/rustc-dev-guide#1141)
- We stopped using allow_internal_unstable a while ago (rust-lang/rustc-dev-guide#1142)
- Change the feature used as an example of stabilizing lib features (rust-lang/rustc-dev-guide#1143)
- We use HIR to do type inference, trait solving and type checking (rust-lang/rustc-dev-guide#1139)
- Add suggested settings note for coc (rust-lang/rustc-dev-guide#1144)
- move 7/8 to prose
- Add a section on keeping things up to date in the git section

## edition-guide

2 commits in 302a115e8f71876dfc884aebb0ca5ccb02b8a962..c74b2a0d6bf55774cf15d69f05dfe05408b8f81a
2021-05-21 10:46:11 -0400 to 2021-06-14 10:48:27 -0700
- Fix lies. (rust-lang/edition-guide#244)
- Add short summaries to all 2021 edition changes. (rust-lang/edition-guide#243)

## embedded-book

1 commits in 7349d173fa28a0bb834cf0264a05286620ef0923..cbec77fbd8eea0c13e390dd9eded1ae200e811d1
2021-05-25 13:59:05 +0000 to 2021-06-10 06:26:32 +0000
- Fix punctuation in c-with-rust.md  (rust-embedded/book#294)
@rustbot rustbot added the rollup A PR which is a rollup label Jun 22, 2021
@Dylan-DPC-zz
Copy link
Author

@bors r+ rollup=never p=5

@bors
Copy link
Contributor

bors commented Jun 22, 2021

📌 Commit bd04f4c has been approved by Dylan-DPC

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 22, 2021
@bors
Copy link
Contributor

bors commented Jun 22, 2021

⌛ Testing commit bd04f4c with merge 574c9dd...

@bors
Copy link
Contributor

bors commented Jun 23, 2021

☀️ Test successful - checks-actions
Approved by: Dylan-DPC
Pushing 574c9dd to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 23, 2021
@bors bors merged commit 574c9dd into rust-lang:master Jun 23, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jun 23, 2021
@Dylan-DPC-zz Dylan-DPC-zz deleted the rollup-aixg3q5 branch June 23, 2021 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants