Remove min_type_alias_impl_trait in favor of type_alias_impl_trait #87501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
oli-obk
reviewed
Jul 27, 2021
spastorino
force-pushed
the
remove-min-tait
branch
from
86ddf26
to
5d05025
Compare
This comment has been minimized.
This comment has been minimized.
spastorino
force-pushed
the
remove-min-tait
branch
from
5d05025
to
92ab093
Compare
|
@bors r+ |
|
📌 Commit 92ab09389af24a39c0a85c96cadf2001048ec6c6 has been approved by |
bors
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
spastorino
force-pushed
the
remove-min-tait
branch
from
92ab093
to
fbf6a22
Compare
spastorino
force-pushed
the
remove-min-tait
branch
from
fbf6a22
to
9629d79
Compare
|
@bors r=oli-obk |
|
📌 Commit 9629d79 has been approved by |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jul 27, 2021
Remove min_type_alias_impl_trait in favor of type_alias_impl_trait r? `@oli-obk`
|
@bors r=oli-obk rollup=always |
|
📌 Commit f16ae7e has been approved by |
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jul 28, 2021
Remove min_type_alias_impl_trait in favor of type_alias_impl_trait r? `@oli-obk`
This was referenced Jul 28, 2021
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 28, 2021
Rollup of 10 pull requests Successful merges: - rust-lang#87315 (Add docs for raw-dylib to unstable book) - rust-lang#87330 (Use hashbrown's `extend_reserve()` in `HashMap`) - rust-lang#87443 (Don't treat git repos as non-existent when `ignore_git` is set) - rust-lang#87453 (Suggest removing unnecessary &mut as help message) - rust-lang#87500 (Document math behind MIN/MAX consts on integers) - rust-lang#87501 (Remove min_type_alias_impl_trait in favor of type_alias_impl_trait) - rust-lang#87507 (SGX mutex is *not* moveable) - rust-lang#87513 (bootstrap.py: change `git log` option to indicate desired behavior) - rust-lang#87523 (Stop creating a reference then immediately dereferencing it.) - rust-lang#87524 (Fix ICE in `diagnostic_hir_wf_check`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
|
I must've missed the conversation on this. Is this gate being removed because the soundness issues were resolved? If I'm remembering things correctly. |
Alexendoo
added a commit
to Alexendoo/glacier
that referenced
this pull request
Jul 29, 2021
It has been removed in favour of type_alias_impl_trait rust-lang/rust#87501
we're moving to a new system in which a min_tait system makes no sense anymore, as everything "just works" and is indeed sound |
|
Awesome! |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jul 29, 2021
…version, r=jackh726 min_type_alias_impl_trait is going to be removed in 1.56 rust-lang#87501 removed `min_type_alias_impl_trait` but meanwhile that PR was approved in homu queue, a new beta was cut so we need to bump the version because it won't be removed in 1.55. r? `@oli-obk` `@bors` rollup=always
fee1-dead
added a commit
to fee1-dead-contrib/rust
that referenced
this pull request
Jul 29, 2021
…version, r=jackh726 min_type_alias_impl_trait is going to be removed in 1.56 rust-lang#87501 removed `min_type_alias_impl_trait` but meanwhile that PR was approved in homu queue, a new beta was cut so we need to bump the version because it won't be removed in 1.55. r? ``@oli-obk`` ``@bors`` rollup=always
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jul 30, 2021
…version, r=jackh726 min_type_alias_impl_trait is going to be removed in 1.56 rust-lang#87501 removed `min_type_alias_impl_trait` but meanwhile that PR was approved in homu queue, a new beta was cut so we need to bump the version because it won't be removed in 1.55. r? ```@oli-obk``` ```@bors``` rollup=always
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @oli-obk