Handle raw string literals in CharClasses - #2983
Merged
Merged
Conversation
nrc
reviewed
Sep 3, 2018
nrc
left a comment
nrc
left a comment
Member
There was a problem hiding this comment.
Looks good except for the nit about unreachable.
| match chr { | ||
| '#' => CharClassesStatus::RawStringPrefix(sharps + 1), | ||
| '"' => CharClassesStatus::LitRawString(sharps), | ||
| _ => CharClassesStatus::Normal, // Unreachable. |
Member
There was a problem hiding this comment.
Here and below, could we use unreachable!?
Contributor
Author
There was a problem hiding this comment.
Hmm, I am not sure... That part should be unreachable in normal code, but could be reachable in macro call.
Member
There was a problem hiding this comment.
OK. I think it would be good to clarify that in the comment, but no need to block the PR on it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2642.