fix: Better test for exercises/10_modules/modules1.rs#2369
Open
JiwaniZakir wants to merge 2 commits intorust-lang:mainfrom
Open
fix: Better test for exercises/10_modules/modules1.rs#2369JiwaniZakir wants to merge 2 commits intorust-lang:mainfrom
JiwaniZakir wants to merge 2 commits intorust-lang:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2339
The
modules1exercise could be passed by commenting out the call inmain, since no test enforced thatmake_sausage()must be public. Adds a#[cfg(test)]block toexercises/10_modules/modules1.rsthat callssausage_factory::make_sausage()directly, and setstest = trueinrustlings-macros/info.tomlso rustlings actually runscargo testagainst the exercise.