Add target names during rust-std downloads

[mrmelon54]

Problem you are trying to solve

Currently the downloads for rust-std don't show the individual target names.

     rust-std installed                       24.74 MiB
     rust-std installed                       27.12 MiB
     rust-std installed                       11.37 MiB

Solution you'd like

I would like rust-std downloads to show the target names.

Notes

No response

[rami3l]

@mrmelon54 Thanks for reporting! I remember it used to look better than this so I doubt whether it's a regression...

The overall idea is that if the rust-std component is not of the same target triple as the toolchain host, the full name should be shown instead of the short name. IIRC we already had that logic somewhere in the API and it was used in the old version. Actually I just checked and the old version used to print the short name plus the target name, essentially giving the full name.

Would you mind drafting a PR? I'm on my phone so I cannot check very precisely, but this might be a single-line fix even... Many thanks 🙏

[mrmelon54]

A two line patch as simple as this gets an ugly but more detailed view of the installing components.

diff --git a/src/dist/manifestation.rs b/src/dist/manifestation.rs
index 50c5d821..eca67b2a 100644
--- a/src/dist/manifestation.rs
+++ b/src/dist/manifestation.rs
@@ -167,7 +167,7 @@ impl Manifestation {
             .iter()
             // The same as the component name's length used in `ComponentBinary::new`
             // As it's used for status output
-            .map(|component| new_manifest.short_name(component).len())
+            .map(|component| new_manifest.name(component).len())
             .max()
             .unwrap_or(0)
             .max(DEFAULT_MIN_NAME_WIDTH);
@@ -773,7 +773,7 @@ impl<'a> ComponentBinary<'a> {
                 Ok(None) => return None,
                 Err(e) => return Some(Err(e)),
             },
-            status: download_cfg.status_for(manifest.short_name(&component).to_owned(), name_width),
+            status: download_cfg.status_for(manifest.name(&component).to_owned(), name_width),
             component,
             manifest,
             download_cfg,

info: downloading 7 components
    cargo-x86_64-unknown-linux-gnu installed                       10.64 MiB (24.40 MiB/s, ETA: 0s)                                         
   clippy-x86_64-unknown-linux-gnu installed                        4.58 MiB (27.57 MiB/s, ETA: 0s)                                         
rust-docs-x86_64-unknown-linux-gnu installed                       21.29 MiB (7.84 MiB/s, ETA: 0s))s)                                       
rust-std-aarch64-unknown-linux-gnu installed                       27.12 MiB (27.32 MiB/s, ETA: 0s)                                         
 rust-std-x86_64-unknown-linux-gnu installed                       28.36 MiB (26.25 MiB/s, ETA: 0s)                                         
    rustc-x86_64-unknown-linux-gnu installed                       76.47 MiB (28.24 MiB/s, ETA: 0s)                                         
  rustfmt-x86_64-unknown-linux-gnu installed                        2.06 MiB                                                                info: default toolchain set to stable-x86_64-unknown-linux-gnu

I would appreciate a decision from the Rustup team about what sort of output format would be acceptable to include the information without cluttering the output.

My first thought would be to show the target after the installed text and only when not matching the local system target.

info: downloading 7 components
    cargo installed                                 10.64 MiB (24.40 MiB/s, ETA: 0s)                                         
   clippy installed                                  4.58 MiB (27.57 MiB/s, ETA: 0s)                                         
rust-docs installed                                 21.29 MiB (7.84 MiB/s, ETA: 0s))s)                                       
 rust-std installed (aarch64-unknown-linux-gnu)     27.12 MiB (27.32 MiB/s, ETA: 0s)                                         
 rust-std installed                                 28.36 MiB (26.25 MiB/s, ETA: 0s)                                         
    rustc installed                                 76.47 MiB (28.24 MiB/s, ETA: 0s)                                         
  rustfmt installed                                  2.06 MiB                                                                info: default toolchain set to stable-x86_64-unknown-linux-gnu

Though just displaying the full rust-std-aarch64-unknown-linux-gnu name on the left instead of trying to move it would probably be fine.

I have submitted a PR using the full rust-std-aarch64-unknown-linux-gnu name but hiding target tuples matching the host.