Display the full names of targets not matching the host target tuple

[mrmelon54]

Displays the target tuple when it doesn't match the host target tuple.

Example output:

info: downloading 7 components
                             cargo installed                       10.64 MiB (29.13 MiB/s, ETA: 0s)                                         
                            clippy installed                        4.58 MiB (27.97 MiB/s, ETA: 0s)                                         
                         rust-docs installed                       21.29 MiB (8.54 MiB/s, ETA: 0s))s)                                       
rust-std-aarch64-unknown-linux-gnu installed                       27.12 MiB (26.71 MiB/s, ETA: 0s)                                         
                          rust-std installed                       28.36 MiB (26.10 MiB/s, ETA: 0s)                                         
                             rustc installed                       76.47 MiB (30.56 MiB/s, ETA: 0s)                                         
                           rustfmt installed                        2.06 MiB                                                                info: default toolchain set to stable-x86_64-unknown-linux-gnu

Resolves #4884

[rami3l]

I just checked and the old version before the regression used to print both short name and target name (but one component per line), so this looks fine.

Actually a width of 100 chars might be okay in this case, given that aarch64-unknown-linux-gnu should be among the long ones already... Thanks again!

PS: I have a small nit here, please squash all changes into one before after addressing it we can merge it.

View changes since this review

[rami3l]

PPS: If there are even longer component names, then we can probably reduce the size of the progress bar itself. The width of the first column has been known since #4768 by @Cloud0310 so I guess it'd be rather easy to do afterwards.

[mrmelon54]

I made the requested change, formatted my code, and squashed my commits.

[rami3l]

I made the requested change, formatted my code, and squashed my commits.

@mrmelon54 Many thanks again!

I have a minor question though... What do you think will be more intuitive to the user, hiding the target tuple based on the current toolchain's host target tuple, or based on the current host's target tuple?

There is a rare case where e.g. Windows x64 machines can install i686 toolchains, and in this case the former will be i686, while the latter will be x64...

View changes since this review

[mrmelon54]

I have a minor question though... What do you think will be more intuitive to the user, hiding the target tuple based on the current toolchain's host target tuple, or based on the current host's target tuple?

There is a rare case where e.g. Windows x64 machines can install i686 toolchains, and in this case the former will be i686, while the latter will be x64...

I thought about that too, the default toolchain might make more sense as a baseline for hiding the target tuple.

[rami3l]

LGTM :)

View changes since this review