feat(config)!: use unqualified names for default_toolchain#4947
Draft
rami3l wants to merge 3 commits into
Draft
Conversation
rami3l
changed the title
Cfg::get_default_resolvable()default_toolchain
rami3l
commented
Jul 9, 2026
| let toolchain = opts.install(cfg)?; | ||
| if let Some(desc) = &toolchain { | ||
| if let Some(partial_desc) = toolchain { | ||
| let desc = &partial_desc.clone().resolve(&cfg.default_host_tuple()?)?; |
Member
Author
There was a problem hiding this comment.
Nit: Pre-existing, but later on we have desc.into() which is converting &ToolchainDesc to something owned. Looks like d494459 (#4930) is not complete? cc @djc
Contributor
There was a problem hiding this comment.
That commit just fixed some instances of it, it didn't claim to fix all of it.
rami3l
commented
Jul 9, 2026
|
|
||
| impl InstallOpts<'_> { | ||
| fn install(self, cfg: &mut Cfg<'_>) -> Result<Option<ToolchainDesc>> { | ||
| fn install(self, cfg: &mut Cfg<'_>) -> Result<Option<PartialToolchainDesc>> { |
Member
Author
There was a problem hiding this comment.
Nit: Pre-existing but this naming is quite confusing, how can InstallOpts::install() be actually not installing anything?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4945.
The breakage should be minimal anyway because the default host tuple almost never changes.