Skip to content

www: align copy icon - #4981

Merged
rami3l merged 1 commit into
rust-lang:mainfrom
geocine:align-copy-icon
Aug 3, 2026
Merged

www: align copy icon#4981
rami3l merged 1 commit into
rust-lang:mainfrom
geocine:align-copy-icon

Conversation

@geocine

@geocine geocine commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Summary

This has been bothering me everytime I visit the rustup.rs website

image

Why

It's misaligned

Validation

Check screenshot

@ChrisDenton

Copy link
Copy Markdown
Member

If the issue is extract vertical spacing messing up the centering, would using div.copy-icon svg { display:bock } have the same effect without needing to manually specifying the offset?

@rami3l

rami3l commented Jul 27, 2026

Copy link
Copy Markdown
Member

If the issue is extract vertical spacing messing up the centering, would using div.copy-icon svg { display:bock } have the same effect without needing to manually specifying the offset?

@ChrisDenton I think the thing with our icon is that IIRC its visual center is not the actual center so that's why manual adjustments have to be made 😓

I'd argue that in "proper" Web frontend an asset library is needed but probably not in this case: so far we are keeping a very minimal Vanilla JS setup.

@ChrisDenton

Copy link
Copy Markdown
Member

For the horizontal center that's true (because there's a bit to one side) but for the vertical center it shouldn't be

@rami3l

rami3l commented Jul 27, 2026

Copy link
Copy Markdown
Member

For the horizontal center that's true (because there's a bit to one side) but for the vertical center it shouldn't be

@ChrisDenton I get it, it's a typo XDD (block, not bock)

@ChrisDenton

Copy link
Copy Markdown
Member

Oops, sorry!

Comment thread www/rustup.css
Comment thread www/rustup.css Outdated
Co-authored-by: rami3l <rami3l@outlook.com>
@rami3l
rami3l enabled auto-merge August 3, 2026 12:55
@rami3l

rami3l commented Aug 3, 2026

Copy link
Copy Markdown
Member

Oops, sorry!

@ChrisDenton I just applied your suggestions and now it looks like so:

image

... I think we can merge this now.

@ChrisDenton

Copy link
Copy Markdown
Member

Great, thanks for testing!

@rami3l
rami3l added this pull request to the merge queue Aug 3, 2026
Merged via the queue into rust-lang:main with commit 62df1e9 Aug 3, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants