refactor(cli/self-update): move process out of InstallOpts - #4998
Merged
Conversation
This way the `process` is always injected when calling methods of `InstallOpts`, whether directly or through `Cfg`.
rami3l
force-pushed
the
refactor/more-installopts
branch
from
August 6, 2026 14:51
54634d1 to
564ba7c
Compare
rami3l
marked this pull request as ready for review
August 6, 2026 14:53
ChrisDenton
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of #4996.
Initially I thought moving
processintoInstallOptsis more convenient since many method calls rely on this value. However since certain operations also rely onCfgwhich also containsprocess, this might cause confusions regarding whichprocessto use. In our particular case, they are fortunately always the same value.With this change,
processis systematically injected when calling methods ofInstallOpts, whether directly or throughCfg.